Skip to content

Commit 496932f

Browse files
author
kornosaurus
committed
Better comments inside selectPlaceholder builder
1 parent 468a580 commit 496932f

File tree

1 file changed

+7
-4
lines changed

1 file changed

+7
-4
lines changed

src/bootstrap-decorator.js

+7-4
Original file line numberDiff line numberDiff line change
@@ -34,12 +34,15 @@ function(decoratorsProvider, sfBuilderProvider, sfPathProvider) {
3434
var option = document.createElement('option');
3535
option.setAttribute('value', '');
3636

37-
// We only want the placeholder to show when we do not have a value on the model.
38-
// We make ngModel builder replace all so we can use $$value$$.
37+
/* We only want the placeholder to show when we do not have a value on the model.
38+
* We make ngModel builder replace all so we can use $$value$$.
39+
*/
3940
option.setAttribute('sf-field-model', 'replaceAll');
4041

41-
// https://github.com/angular/angular.js/issues/12190#issuecomment-115277040
42-
// emptyOption.attr('selected', true) does not like the ng-if comment.
42+
/* https://github.com/angular/angular.js/issues/12190#issuecomment-115277040
43+
* angular > 1.4 does a emptyOption.attr('selected', true)
44+
* which does not like the ng-if comment.
45+
*/
4346
if (angular.version.major === 1 && angular.version.minor < 4) {
4447
option.setAttribute('ng-if', '!$$value$$');
4548
} else {

0 commit comments

Comments
 (0)