Skip to content

ChangeRecord error #97

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kenjiqq opened this issue Jul 20, 2014 · 4 comments
Closed

ChangeRecord error #97

kenjiqq opened this issue Jul 20, 2014 · 4 comments
Milestone

Comments

@kenjiqq
Copy link

kenjiqq commented Jul 20, 2014

I'm getting an error that i cannot figure out, any clue what this can be?

Unknown changeRecord type: add angular-data.js:436
Object {type: "add", object: Object, name: "fullName"}
 angular-data.js:437
diffObjectFromChangeRecords angular-data.js:437
createObject.check angular-data.js:344
Observer.internalCallback angular-data.js:185
Observer.boundInternalCallback
@kenjiqq
Copy link
Author

kenjiqq commented Jul 20, 2014

It seems to be caused by computed properties, when i have 2 of them on the same resource. If i remove one of them(doesn't matter which one) the errors are not there

@kenjiqq
Copy link
Author

kenjiqq commented Jul 20, 2014

Hmm or not, it happens with only 1 computed property as well, except when that property is used as the idAttribute of the resource, then there are no errors

edit: and the reason it seems to with if you use the computed property as the ID is that this function diffObjectFromChangeRecords is not called then. But it is if the property is not the ID

@jmdobry
Copy link
Member

jmdobry commented Jul 20, 2014

This is fixed in #95 and will be released with 0.10.1 today.

It's caused by Object.observe landing in Chrome 36, and angular-data using an outdated version of observe-js.

@kenjiqq
Copy link
Author

kenjiqq commented Jul 20, 2014

Ah great! Was stopping me from finishing up some work before a short vacation!

And that explains why i had not noticed it before, was checking out old commits to try and figure out when it showed up

@jmdobry jmdobry added this to the 0.10.1 milestone Jul 20, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants