Issue with v1.5.1 on Bower: pulling in wrong code

[OverZealous]

Something is wrong with bower (and more specifically, the github zip for 1.5.1), both are coming with the wrong code, it looks like the stuff from 1.5.0, because it's missing the "changesOnly" fix.

[OverZealous]

I think I found the issue, but I'm confused, because the dist/ folder on github doesn't match the commit.

But the answer is that the dist folder is outdated on github, and needs to be updated (I guess?).

[jmdobry]

What's the "changesOnly" fix, and which commit are you referring to?

[OverZealous]

Sorry if I was confusing, I'm referring to commit 2bb8fb7, which is tagged as 1.5.1 on the v1 branch. I was referring to the fix for #258 which was about nested fields. Right now, I can tell you my original issue was invalid, I apologize.

I'll start over: I was using the changesOnly option for the save method. I have an object with nested properties, as mentioned in #258. When I tried to submit the object, it doesn't even send if the only change is within a nested field.

I kept getting confused, because the commit showed a changed diffObjectFromOldObject method, but the file I was pulling down from Github didn't. Well, I just now realized that there's two different diffObjectFromOldObject methods, and only the one in utils.js has been modified. The one that comes from the Object.observe polyfill still uses equality, and doesn't check nested objects.

I'm going to close this issue, as it's invalid as it stands. I'll do some more research, and see if I can figure out why it's not submitting when changesOnly is set.

[jmdobry]

I forgot about the diffObjectFromOldObject function in the observe-js code. I probably should fix that one to use a deep equals as well.

[OverZealous]

It turns out that's not where the issue came from. I made a new issue for the real problem, which relates to deepMixin.

[jmdobry]

Work for angular-data 1.x happens on the v1 branch. Were you looking at master?

[OverZealous]

No, it wasn't related to bower or the version—that was a mistake on my part because I didn't realize there was more than diffObjectFromObject function. I'm definitely on the right branch on my copy. The issue that led me down this path is almost certainly the issue with deepMixin, which is what you are using to make "backups" of the data for change detection.

It's all in #262.