Skip to content

Commit c0b1c0d

Browse files
bors[bot]Johnathan Van Why
and
Johnathan Van Why
authored
Merge tock#296
296: [RFC] Allow PR authors to merge their own PR. r=jrvanwhy a=jrvanwhy [Rendered](https://github.com/jrvanwhy/libtock-rs/blob/author-submit/doc/CodeReview.md) This change only applies to PRs authored by `libtock-rs` code owners. To date, we have asked PR reviewers to merge PRs. In practice, this means the PR author writes something like "This PR is ready to merge" when it is ready to merge, and the PR reviewers respond with `bors r+`. I do not believe that a PR reviewer has given a different response. This seems like an unnecessary back-and-forth. Co-authored-by: Johnathan Van Why <[email protected]>
2 parents 912e54b + 19077c2 commit c0b1c0d

File tree

1 file changed

+2
-3
lines changed

1 file changed

+2
-3
lines changed

doc/CodeReview.md

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -15,9 +15,8 @@ PR to `libtock-rs` can be divided into two categories:
1515

1616
The owners of `libtock-rs` (listed [below](#owners)) determine whether a PR is
1717
an upkeep PR or a significant PR. PRs should be merged by the `libtock-rs`
18-
owners rather than the PR's author. PRs authored by `libtock-rs` owners should
19-
be merged by a reviewer rather than their author. In general, PRs should be
20-
merged using a `bors r+` command rather than the GitHub UI (see the [bors
18+
owners rather than the PR's author. In general, PRs should be merged using a
19+
`bors r+` command rather than the GitHub UI (see the [bors
2120
documentation](https://bors.tech/documentation/) for more information on bors).
2221

2322
A PR may only be merged when all of the following are true:

0 commit comments

Comments
 (0)