COMPAT: PyPy can only call PyList_GET_SIZE on a PyListObject

BUG: bring implementation into compliance with cython documentation

BUG: fix improper use of conditional compilation

closes pandas-dev#15080

Author: mattip

pandas/lib.pyx

@@ -26,10 +26,13 @@ from cpython cimport (PyDict_New, PyDict_GetItem, PyDict_SetItem,
                       PyBytes_GET_SIZE,
                       PyUnicode_GET_SIZE)
 
-try:
-    from cpython cimport PyString_GET_SIZE
-except ImportError:
+cdef extern from "Python.h":
+    int PY_MAJOR_VERSION
+
+if PY_MAJOR_VERSION >= 3:
     from cpython cimport PyUnicode_GET_SIZE as PyString_GET_SIZE
+else:
+    from cpython cimport PyString_GET_SIZE
 
 cdef extern from "Python.h":
     Py_ssize_t PY_SSIZE_T_MAX

pandas/src/hashtable_class_helper.pxi.in

@@ -691,7 +691,11 @@ cdef class PyObjectHashTable(HashTable):
 
     def __dealloc__(self):
         if self.table is not NULL:
-            self.destroy()
+            # cython documentation -
+            # "don’t call any other methods of the object"
+            # self.destroy()
+            kh_destroy_pymap(self.table)
+            self.table = NULL
 
     def __len__(self):
         return self.table.size

pandas/src/ujson/python/JSONtoObj.c

@@ -427,7 +427,11 @@ int Object_npyObjectAddKey(void *prv, JSOBJ obj, JSOBJ name, JSOBJ value) {
 
     // only fill label array once, assumes all column labels are the same
     // for 2-dimensional arrays.
+#ifdef PYPY_VERSION
+    if (PyObject_GET_SIZE(npyarr->labels[labelidx]) <= npyarr->elcount) {
+#else
     if (PyList_GET_SIZE(npyarr->labels[labelidx]) <= npyarr->elcount) {
+#endif
         PyList_Append(npyarr->labels[labelidx], label);
     }