Build: Enable the strict ESLint rule

Author: mgol

build/release-test.js

@@ -1,3 +1,5 @@
+"use strict";
+
 var shell = require( "shelljs" );
 var Release = {
 	define: function( props ) {

build/release.js

@@ -1,3 +1,5 @@
+"use strict";
+
 module.exports = function( Release ) {
 
 var crypto = require( "crypto" );

build/tasks/build.js

@@ -1,7 +1,7 @@
-module.exports = function( grunt ) {
-
 "use strict";
 
+module.exports = function( grunt ) {
+
 grunt.registerTask( "clean", function() {
 	require( "rimraf" ).sync( "dist" );
 } );

build/tasks/testswarm.js

@@ -1,7 +1,7 @@
-module.exports = function( grunt ) {
-
 "use strict";
 
+module.exports = function( grunt ) {
+
 var versions = {
 		"git": "git",
 		"3.x-git": "3.x-git",

external/qunit-assert-classes/qunit-assert-classes.js

@@ -1,4 +1,6 @@
 ( function( factory ) {
+	"use strict";
+
 	if ( typeof define === "function" && define.amd ) {
 
 		// AMD. Register as an anonymous module.

tests/.eslintrc.json

@@ -10,14 +10,13 @@
 	},
 
 	"rules": {
-//		"strict": [ "error", "function" ]
+		"strict": [ "error", "function" ],
 
 		// The following rule is relaxed due to too many violations:
 		"no-unused-vars": [ "error", { "vars": "all", "args": "after-used" } ],
 
 		// Too many violations:
-		"max-len": "off",
-		"strict": "off"
+		"max-len": "off"
 	},
 
 	"globals": {

tests/lib/bootstrap.js

@@ -1,4 +1,5 @@
 ( function() {
+"use strict";
 
 var DEFAULT_JQUERY_VERSION = "1.12.4";
 

tests/lib/common.js

@@ -3,6 +3,7 @@ define( [
 	"jquery",
 	"lib/helper"
 ], function( QUnit, $, helper ) {
+"use strict";
 
 var exports = {};
 

tests/lib/css.js

@@ -1,4 +1,5 @@
 ( function() {
+"use strict";
 
 function includeStyle( url ) {
 	document.write( "<link rel='stylesheet' href='../../../" + url + "'>" );

tests/lib/qunit-assert-domequal.js

@@ -8,6 +8,7 @@ define( [
 	"qunit",
 	"jquery"
 ], function( QUnit, $ ) {
+"use strict";
 
 var domEqual = QUnit.assert.domEqual = function( selector, modifier, message ) {
 

tests/lib/qunit.js

@@ -6,6 +6,7 @@ define( [
 	"lib/qunit-assert-domequal",
 	"phantom-bridge"
 ], function( QUnit, $ ) {
+"use strict";
 
 QUnit.config.autostart = false;
 QUnit.config.requireExpects = true;

tests/unit/accordion/core.js

@@ -4,6 +4,7 @@ define( [
 	"./helper",
 	"ui/widgets/accordion"
 ], function( QUnit, $, testHelper ) {
+"use strict";
 
 var beforeAfterEach = testHelper.beforeAfterEach,
 	state = testHelper.state;

tests/unit/accordion/events.js

@@ -4,6 +4,7 @@ define( [
 	"./helper",
 	"ui/widgets/accordion"
 ], function( QUnit, $, testHelper ) {
+"use strict";
 
 var beforeAfterEach = testHelper.beforeAfterEach,
 	state = testHelper.state;

tests/unit/accordion/helper.js

@@ -4,6 +4,7 @@ define( [
 	"lib/helper",
 	"ui/widgets/accordion"
 ], function( QUnit, $, helper ) {
+"use strict";
 
 return $.extend( helper, {
 	equalHeight: function( assert, accordion, height ) {

tests/unit/accordion/methods.js

@@ -4,6 +4,7 @@ define( [
 	"./helper",
 	"ui/widgets/accordion"
 ], function( QUnit, $, testHelper ) {
+"use strict";
 
 var equalHeight = testHelper.equalHeight,
 	beforeAfterEach = testHelper.beforeAfterEach,

tests/unit/accordion/options.js

@@ -4,6 +4,7 @@ define( [
 	"./helper",
 	"ui/widgets/accordion"
 ], function( QUnit, $, testHelper ) {
+"use strict";
 
 var equalHeight = testHelper.equalHeight,
 	beforeAfterEach = testHelper.beforeAfterEach,

tests/unit/autocomplete/core.js

@@ -4,6 +4,7 @@ define( [
 	"lib/helper",
 	"ui/widgets/autocomplete"
 ], function( QUnit, $, helper ) {
+"use strict";
 
 QUnit.module( "autocomplete: core", { afterEach: helper.moduleAfterEach }  );
 

tests/unit/autocomplete/events.js

@@ -4,6 +4,7 @@ define( [
 	"lib/helper",
 	"ui/widgets/autocomplete"
 ], function( QUnit, $, helper ) {
+"use strict";
 
 QUnit.module( "autocomplete: events", { afterEach: helper.moduleAfterEach }  );
 

tests/unit/autocomplete/methods.js

@@ -4,6 +4,7 @@ define( [
 	"lib/helper",
 	"ui/widgets/autocomplete"
 ], function( QUnit, $, helper ) {
+"use strict";
 
 QUnit.module( "autocomplete: methods", { afterEach: helper.moduleAfterEach }  );
 

tests/unit/autocomplete/options.js

@@ -4,6 +4,7 @@ define( [
 	"lib/helper",
 	"ui/widgets/autocomplete"
 ], function( QUnit, $, helper ) {
+"use strict";
 
 QUnit.module( "autocomplete: options", { afterEach: helper.moduleAfterEach }  );
 

tests/unit/button/core.js

@@ -5,6 +5,7 @@ define( [
 	"ui/safe-active-element",
 	"ui/widgets/button"
 ], function( QUnit, $, helper ) {
+"use strict";
 
 QUnit.module( "Button: core", { afterEach: helper.moduleAfterEach }  );
 

tests/unit/button/deprecated.js

@@ -4,6 +4,7 @@ define( [
 	"lib/helper",
 	"ui/widgets/button"
 ], function( QUnit, $, helper ) {
+"use strict";
 
 QUnit.module( "Button (deprecated): core", { afterEach: helper.moduleAfterEach }  );
 

tests/unit/button/events.js

@@ -4,6 +4,7 @@ define( [
 	"lib/helper",
 	"ui/widgets/button"
 ], function( QUnit, $, helper ) {
+"use strict";
 
 QUnit.module( "Button: events", { afterEach: helper.moduleAfterEach }  );
 

tests/unit/button/methods.js

@@ -4,6 +4,7 @@ define( [
 	"lib/helper",
 	"ui/widgets/button"
 ], function( QUnit, $, helper ) {
+"use strict";
 
 QUnit.module( "Button: methods", { afterEach: helper.moduleAfterEach }  );
 

tests/unit/button/options.js

@@ -4,6 +4,7 @@ define( [
 	"lib/helper",
 	"ui/widgets/button"
 ], function( QUnit, $, helper ) {
+"use strict";
 
 QUnit.module( "button: options", { afterEach: helper.moduleAfterEach }  );
 

tests/unit/checkboxradio/core.js

@@ -4,6 +4,7 @@ define( [
 	"lib/helper",
 	"ui/widgets/checkboxradio"
 ], function( QUnit, $, helper ) {
+"use strict";
 
 QUnit.module( "Checkboxradio: core", { afterEach: helper.moduleAfterEach }  );
 

tests/unit/checkboxradio/events.js

@@ -4,6 +4,7 @@ define( [
 	"lib/helper",
 	"ui/widgets/checkboxradio"
 ], function( QUnit, $, helper ) {
+"use strict";
 
 QUnit.module( "Checkboxradio: events", { afterEach: helper.moduleAfterEach }  );
 

tests/unit/checkboxradio/methods.js

@@ -4,6 +4,7 @@ define( [
 	"lib/helper",
 	"ui/widgets/checkboxradio"
 ], function( QUnit, $, helper ) {
+"use strict";
 
 QUnit.module( "Checkboxradio: methods", { afterEach: helper.moduleAfterEach }  );
 

tests/unit/checkboxradio/options.js

@@ -4,6 +4,7 @@ define( [
 	"lib/helper",
 	"ui/widgets/checkboxradio"
 ], function( QUnit, $, helper ) {
+"use strict";
 
 QUnit.module( "Checkboxradio: options", { afterEach: helper.moduleAfterEach }  );
 

tests/unit/controlgroup/core.js

@@ -8,6 +8,7 @@ define( [
 	"ui/widgets/button",
 	"ui/widgets/spinner"
 ], function( QUnit, $, helper ) {
+"use strict";
 
 QUnit.module( "Controlgroup: Core", { afterEach: helper.moduleAfterEach }  );
 

tests/unit/controlgroup/methods.js

@@ -8,6 +8,7 @@ define( [
 	"ui/widgets/button",
 	"ui/widgets/spinner"
 ], function( QUnit, $, helper ) {
+"use strict";
 
 QUnit.module( "Controlgroup: methods", { afterEach: helper.moduleAfterEach }  );
 

tests/unit/controlgroup/options.js

@@ -8,6 +8,7 @@ define( [
 	"ui/widgets/button",
 	"ui/widgets/spinner"
 ], function( QUnit, $, helper ) {
+"use strict";
 
 QUnit.module( "Controlgroup: options", { afterEach: helper.moduleAfterEach }  );
 

tests/unit/core/core.js

@@ -7,6 +7,7 @@ define( [
 	"ui/labels",
 	"ui/unique-id"
 ], function( QUnit, $, common, helper ) {
+"use strict";
 
 QUnit.module( "core - jQuery extensions", { afterEach: helper.moduleAfterEach }  );
 

tests/unit/core/selector.js

@@ -6,6 +6,7 @@ define( [
 	"ui/focusable",
 	"ui/tabbable"
 ], function( QUnit, $, helper ) {
+"use strict";
 
 QUnit.module( "core - selectors", { afterEach: helper.moduleAfterEach }  );
 

tests/unit/datepicker/core.js

@@ -7,6 +7,7 @@ define( [
 	"ui/widgets/datepicker",
 	"ui/i18n/datepicker-he"
 ], function( QUnit, $, common, helper, testHelper ) {
+"use strict";
 
 QUnit.module( "datepicker: core", {
 	beforeEach: function() {

tests/unit/datepicker/events.js

@@ -4,6 +4,7 @@ define( [
 	"./helper",
 	"ui/widgets/datepicker"
 ], function( QUnit, $, testHelper ) {
+"use strict";
 
 var beforeAfterEach = testHelper.beforeAfterEach;
 

tests/unit/datepicker/helper.js

@@ -4,6 +4,7 @@ define( [
 	"lib/helper",
 	"ui/widgets/datepicker"
 ], function( QUnit, $, helper ) {
+"use strict";
 
 return $.extend( helper, {
 	addMonths: function( date, offset ) {

tests/unit/datepicker/methods.js

@@ -4,6 +4,7 @@ define( [
 	"./helper",
 	"ui/widgets/datepicker"
 ], function( QUnit, $, testHelper ) {
+"use strict";
 
 var beforeAfterEach = testHelper.beforeAfterEach;
 

tests/unit/datepicker/options.js

@@ -8,6 +8,7 @@ define( [
 	"ui/i18n/datepicker-zh-CN",
 	"ui/ie"
 ], function( QUnit, $, testHelper ) {
+"use strict";
 
 var beforeAfterEach = testHelper.beforeAfterEach;
 

tests/unit/dialog/core.js

@@ -4,6 +4,7 @@ define( [
 	"lib/helper",
 	"ui/widgets/dialog"
 ], function( QUnit, $, helper ) {
+"use strict";
 
 // TODO add afterEach callback to remove dialogs
 QUnit.module( "dialog: core", { afterEach: helper.moduleAfterEach }  );

tests/unit/dialog/deprecated.js

@@ -4,6 +4,7 @@ define( [
 	"lib/helper",
 	"ui/widgets/dialog"
 ], function( QUnit, $, helper ) {
+"use strict";
 
 QUnit.module( "dialog (deprecated): options", { afterEach: helper.moduleAfterEach }  );
 

tests/unit/dialog/events.js

@@ -4,6 +4,7 @@ define( [
 	"./helper",
 	"ui/widgets/dialog"
 ], function( QUnit, $, testHelper ) {
+"use strict";
 
 QUnit.module( "dialog: events", { afterEach: testHelper.moduleAfterEach }  );
 

tests/unit/dialog/helper.js

@@ -4,6 +4,7 @@ define( [
 	"lib/helper",
 	"ui/widgets/dialog"
 ], function( QUnit, $, helper ) {
+"use strict";
 
 return $.extend( helper, {
 	drag: function( element, handle, dx, dy ) {

tests/unit/dialog/methods.js

@@ -4,6 +4,7 @@ define( [
 	"lib/helper",
 	"ui/widgets/dialog"
 ], function( QUnit, $, helper ) {
+"use strict";
 
 QUnit.module( "dialog: methods", {
 	afterEach: function() {

tests/unit/dialog/options.js

@@ -7,6 +7,7 @@ define( [
 	"ui/effects/effect-blind",
 	"ui/effects/effect-explode"
 ], function( QUnit, $, helper, testHelper ) {
+"use strict";
 
 QUnit.module( "dialog: options", { afterEach: helper.moduleAfterEach }  );
 

tests/unit/draggable/core.js

@@ -7,6 +7,7 @@ define( [
 	"ui/widgets/droppable",
 	"ui/widgets/resizable"
 ], function( QUnit, $, helper, testHelper ) {
+"use strict";
 
 QUnit.module( "draggable: core", { afterEach: helper.moduleAfterEach }  );
 

tests/unit/draggable/events.js

@@ -4,6 +4,7 @@ define( [
 	"lib/helper",
 	"ui/widgets/draggable"
 ], function( QUnit, $, helper ) {
+"use strict";
 
 var element;
 

tests/unit/draggable/helper.js

@@ -4,6 +4,7 @@ define( [
 	"lib/helper",
 	"ui/widgets/draggable"
 ], function( QUnit, $, helper ) {
+"use strict";
 
 return $.extend( helper, {
 

tests/unit/draggable/methods.js

@@ -5,6 +5,7 @@ define( [
 	"./helper",
 	"ui/widgets/draggable"
 ], function( QUnit, $, helper, testHelper ) {
+"use strict";
 
 var element;