Widget: Avoid tracking remove event handlers for classes options

scottgonzalez · scottgonzalez · commit ac971a638410 · 2016-11-16T14:42:34.000-05:00
Fixes #15082
Fixes #15095
diff --git a/ui/widget.js b/ui/widget.js
@@ -514,9 +514,9 @@ $.Widget.prototype = {
 			}
 		}
 
-		this._on( options.element, {
-			"remove": "_untrackClassesElement"
-		} );
+		// Don't use ._on() because we want to avoid additional processing for
+		// tracking the event bindings.
+		options.element.one( "remove", $.proxy( this, "_untrackClassesElement" ) );
 
 		if ( options.keys ) {
 			processClassString( options.keys.match( /\S+/g ) || [], true );

Original file line number	Diff line number	Diff line change
`@@ -514,9 +514,9 @@ $.Widget.prototype = {`
`514`	`514`	`}`
`515`	`515`	`}`
`516`	`516`
`517`		`- this._on( options.element, {`
`518`		`- "remove": "_untrackClassesElement"`
`519`		`- } );`
	`517`	`+ // Don't use ._on() because we want to avoid additional processing for`
	`518`	`+ // tracking the event bindings.`
	`519`	`+ options.element.one( "remove", $.proxy( this, "_untrackClassesElement" ) );`
`520`	`520`
`521`	`521`	`if ( options.keys ) {`
`522`	`522`	`processClassString( options.keys.match( /\S+/g ) \|\| [], true );`