Skip to content

Commit 2ff8667

Browse files
Revert "BUG: ArrayManager construction unwanted copy (pandas-dev#42689)"
This reverts commit cb3b4e4.
1 parent 5f96f28 commit 2ff8667

File tree

2 files changed

+6
-3
lines changed

2 files changed

+6
-3
lines changed

pandas/core/internals/construction.py

+2-2
Original file line numberDiff line numberDiff line change
@@ -349,14 +349,14 @@ def ndarray_to_mgr(
349349
if dtype is None and is_object_dtype(values.dtype):
350350
arrays = [
351351
ensure_wrapped_if_datetimelike(
352-
maybe_infer_to_datetimelike(values[:, i])
352+
maybe_infer_to_datetimelike(values[:, i].copy())
353353
)
354354
for i in range(values.shape[1])
355355
]
356356
else:
357357
if is_datetime_or_timedelta_dtype(values.dtype):
358358
values = ensure_wrapped_if_datetimelike(values)
359-
arrays = [values[:, i] for i in range(values.shape[1])]
359+
arrays = [values[:, i].copy() for i in range(values.shape[1])]
360360

361361
return ArrayManager(arrays, [index, columns], verify_integrity=False)
362362

pandas/tests/frame/methods/test_values.py

+4-1
Original file line numberDiff line numberDiff line change
@@ -226,7 +226,10 @@ def test_values_lcd(self, mixed_float_frame, mixed_int_frame):
226226

227227

228228
class TestPrivateValues:
229-
def test_private_values_dt64tz(self, request):
229+
def test_private_values_dt64tz(self, using_array_manager, request):
230+
if using_array_manager:
231+
mark = pytest.mark.xfail(reason="doesn't share memory")
232+
request.node.add_marker(mark)
230233

231234
dta = date_range("2000", periods=4, tz="US/Central")._data.reshape(-1, 1)
232235

0 commit comments

Comments
 (0)