Skip to content

Remark - case_1_bike_count #153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jonasvdd opened this issue Dec 20, 2021 · 3 comments · Fixed by plovercode/course-python-data#29
Closed

Remark - case_1_bike_count #153

jonasvdd opened this issue Dec 20, 2021 · 3 comments · Fixed by plovercode/course-python-data#29

Comments

@jonasvdd
Copy link

image

I would propose to use the to_series() method as this allows for method-chaining (instead of encapsulating in the pd.Series constructor), thus increasing readability

@stijnvanhoey
Copy link
Collaborator

Indeed. Actually, @jorisvandenbossche, focusing more on method-chaining is worthwhile to check in general as it would increase consistency.

@jorisvandenbossche
Copy link
Owner

Yes, to_series is better here (I think our first version of the course predates this method :))
Sidenote: pandas should maybe just add a diff() method to Index as well.

@jorisvandenbossche
Copy link
Owner

Wanted to open an issue, but apparently there is already one -> pandas-dev/pandas#19708

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants