Skip to content

Commit b552ec2

Browse files
committed
fix: don't replace err variable in nested check (go-gitea#22416)
We can use `:=` to make `err` local to the if-scope instead of overwriting the `err` in outer scope. Signed-off-by: jolheiser <[email protected]>
1 parent 421d879 commit b552ec2

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

services/repository/check.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -83,7 +83,7 @@ func GitGcRepos(ctx context.Context, timeout time.Duration, args ...git.CmdArg)
8383
if err != nil {
8484
log.Error("Repository garbage collection failed for %v. Stdout: %s\nError: %v", repo, stdout, err)
8585
desc := fmt.Sprintf("Repository garbage collection failed for %s. Stdout: %s\nError: %v", repo.RepoPath(), stdout, err)
86-
if err = system_model.CreateRepositoryNotice(desc); err != nil {
86+
if err := system_model.CreateRepositoryNotice(desc); err != nil {
8787
log.Error("CreateRepositoryNotice: %v", err)
8888
}
8989
return fmt.Errorf("Repository garbage collection failed in repo: %s: Error: %w", repo.FullName(), err)
@@ -93,7 +93,7 @@ func GitGcRepos(ctx context.Context, timeout time.Duration, args ...git.CmdArg)
9393
if err := repo_module.UpdateRepoSize(ctx, repo); err != nil {
9494
log.Error("Updating size as part of garbage collection failed for %v. Stdout: %s\nError: %v", repo, stdout, err)
9595
desc := fmt.Sprintf("Updating size as part of garbage collection failed for %s. Stdout: %s\nError: %v", repo.RepoPath(), stdout, err)
96-
if err = system_model.CreateRepositoryNotice(desc); err != nil {
96+
if err := system_model.CreateRepositoryNotice(desc); err != nil {
9797
log.Error("CreateRepositoryNotice: %v", err)
9898
}
9999
return fmt.Errorf("Updating size as part of garbage collection failed in repo: %s: Error: %w", repo.FullName(), err)

0 commit comments

Comments
 (0)