Skip to content

Commit 2c13c93

Browse files
[ruby] Fix Case Where Field Access Prepends @ on CONST (#4789)
There was a case that would mistakenly prepend `@` on a member that start with a capitalized first letter.
1 parent 10ab72d commit 2c13c93

File tree

1 file changed

+2
-3
lines changed

1 file changed

+2
-3
lines changed

joern-cli/frontends/rubysrc2cpg/src/main/scala/io/joern/rubysrc2cpg/astcreation/AstForExpressionsCreator.scala

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -866,9 +866,8 @@ trait AstForExpressionsCreator(implicit withSchemaValidation: ValidationMode) {
866866

867867
protected def astForFieldAccess(node: MemberAccess, stripLeadingAt: Boolean = false): Ast = {
868868
val (memberName, memberCode) = node.target match {
869-
case _ if stripLeadingAt => node.memberName -> node.memberName.stripPrefix("@")
870-
case _: TypeIdentifier => node.memberName -> node.memberName
871-
case _: SelfIdentifier => s"@${node.memberName}" -> node.memberName
869+
case _ if stripLeadingAt => node.memberName -> node.memberName.stripPrefix("@")
870+
case _: TypeIdentifier => node.memberName -> node.memberName
872871
case _ if !node.memberName.startsWith("@") && node.memberName.headOption.exists(_.isLower) =>
873872
s"@${node.memberName}" -> node.memberName
874873
case _ => node.memberName -> node.memberName

0 commit comments

Comments
 (0)