Skip to content

Commit 87dfd00

Browse files
author
Lukas Smith
committed
- MFH
1 parent 4e0a8a0 commit 87dfd00

File tree

1 file changed

+46
-29
lines changed

1 file changed

+46
-29
lines changed

README.CVS-RULES

Lines changed: 46 additions & 29 deletions
Original file line numberDiff line numberDiff line change
@@ -1,24 +1,31 @@
1+
====================
2+
CVS Commit Rules
3+
====================
4+
15
This is the first file you should be reading after you get your CVS account.
26
We'll assume you're basically familiar with CVS, but feel free to post
3-
your questions on the mailing list. Please have a look at
7+
your questions on the mailing list. Please have a look at
48
http://cvsbook.red-bean.com/ for more detailed information on CVS.
59

610
PHP is developed through the efforts of a large number of people.
711
Collaboration is a Good Thing(tm), and CVS lets us do this. Thus, following
8-
some basic rules with regards to CVS usage will:
12+
some basic rules with regards to CVS usage will::
913

1014
a. Make everybody happier, especially those responsible for maintaining
1115
the CVS itself.
16+
1217
b. Keep the changes consistently well documented and easily trackable.
18+
1319
c. Prevent some of those 'Oops' moments.
14-
d. Increase the general level of good will on planet Earth.
1520

21+
d. Increase the general level of good will on planet Earth.
1622

17-
Having said that, here are the organizational rules:
23+
Having said that, here are the organizational rules::
1824

1925
1. Respect other people working on the project.
2026

21-
2. Discuss any significant changes on the list before committing.
27+
2. Discuss any significant changes on the list before committing and get
28+
confirmation from the release manager for the given branch.
2229

2330
3. Look at EXTENSIONS file to see who is the primary maintainer of
2431
the code you want to contribute to.
@@ -30,30 +37,38 @@ Having said that, here are the organizational rules:
3037

3138
6. Test your changes before committing them. We mean it. Really.
3239
To do so use "make test".
33-
40+
3441
7. For development use the --enable-maintainer-zts switch to ensure your
3542
code handles TSRM correctly and doesn't break for thos who need that.
3643

37-
Currently we have the following branches in use:
38-
HEAD Will become PHP 6.0. This CVS branch is for active development.
39-
PHP_5_2 Is used to release the PHP 5.2.x series. Only minor feature
40-
enhancements may go in here, but please keep that as infrequent as
41-
possible.
42-
PHP_5_1 This branch is closed.
43-
PHP_4_4 Is used to release the PHP 4.4.x series. Only bugfixes are permitted
44-
on this branch (Consult the releasemaster prior to commit).
45-
PHP_4_3 This branch is closed.
44+
Currently we have the following branches in use::
45+
46+
HEAD Will become PHP 6.0. This CVS branch is for active development.
47+
48+
PHP_5_3 Is used to release the PHP 5.3.x series. It still allows for
49+
larger enhancements.
4650

47-
The next few rules are more of a technical nature.
51+
PHP_5_2 Is used to release the PHP 5.2.x series. Only minor feature
52+
enhancements may go in here, but please keep that as infrequent as
53+
possible.
54+
55+
PHP_5_1 This branch is closed.
56+
57+
PHP_4_4 Is used to release the PHP 4.4.x series. Only bugfixes are permitted
58+
on this branch (Consult the releasemaster prior to commit).
59+
60+
PHP_4_3 This branch is closed.
61+
62+
The next few rules are more of a technical nature::
4863

4964
1. DO NOT TOUCH ChangeLog! It is automagically updated from the commit
5065
messages every day. Woe be to those who attempt to mess with it.
5166

5267
2. All news updates intended for public viewing, such as new features,
53-
bug fixes, improvements, etc., should go into the NEWS file.
54-
68+
bug fixes, improvements, etc., should go into the NEWS file.
69+
5570
NB! Lines, starting with @ will go automagically into NEWS file, but
56-
this is NOT recommended, though. Please, add news entries directly to
71+
this is NOT recommended, though. Please, add news entries directly to
5772
NEWS file and don't forget to keep them adjusted and sorted.
5873

5974
3. Do not commit multiple file and dump all messages in one commit. If you
@@ -80,21 +95,23 @@ If a line begins with #, it is taken to be a comment and will not appear
8095
in the ChangeLog. Everything else goes into the ChangeLog.
8196

8297
It is important to note that if your comment or news logline spans multiple
83-
lines, you have to put # at the beginning of _every_ such line.
98+
lines, you have to put # at the beginning of _every_ such line.
8499

85100
Example. Say you modified two files, datetime.c and string.c. In datetime.c you
86101
added a new format option for the date() function, and in string.c you fixed a
87102
memory leak in php_trim(). Don't commit both of these at once. Commit them
88103
separately and try to make sure your commit messages look something like the
89104
following.
90105

91-
For datetime.c:
92-
- Added new 'K' format modifier to date() for printing out number of days until
93-
New Year's Eve.
106+
For datetime.c::
107+
108+
- Added new 'K' format modifier to date() for printing out number of days
109+
until New Year's Eve.
110+
111+
For string.c::
94112

95-
For string.c:
96-
- Fixed a memory leak in php_trim() resulting from improper use of zval_dtor().
97-
#- Man, that thing was leaking all over the place!
113+
- Fixed a memory leak in php_trim() resulting from improper use of zval_dtor().
114+
#- Man, that thing was leaking all over the place!
98115

99116
The # lines will be omitted from the ChangeLog automagically.
100117

@@ -106,13 +123,13 @@ If you fix some bugs, you should note the bug ID numbers in your
106123
commit message. Bug ID should be prefixed by "#" for easier access to
107124
bug report when developers are browsing CVS via LXR or Bonsai.
108125

109-
Example:
126+
Example::
110127

111-
Fixed bug #14016 (pgsql notice handler double free crash bug.)
128+
Fixed bug #14016 (pgsql notice handler double free crash bug.)
112129

113130
If you don't see your messages in ChangeLog right away, don't worry!
114131
These files are updated once a day, so your stuff will not show up until
115-
somewhat later.
132+
somewhat later.
116133

117134
You can use LXR (http://lxr.php.net/) and Bonsai (http://bonsai.php.net/)
118135
to look at PHP CVS repository in various ways.

0 commit comments

Comments
 (0)