use ensure_clean rather than explicit os.remove pandas-dev#34384

I have made a start at this issue pandas-dev#34384. Please let me know if I am along the right lines (beginner contributor).

I've left a space in code_checks.sh where I expect to implement the check for instances of 'os.remove' throughout the code.

Author: jnecus

ci/code_checks.sh

@@ -266,7 +266,12 @@ if mods:
     sys.exit(len(mods))
     "
     RET=$(($RET + $?)) ; echo $MSG "DONE"
-
+	
+	MSG='Check code for instances of os.remove' ; echo $MSG
+	#TODO: insert check here Issue #34384
+	RET=$(($RET + $?)) ; echo $MSG "DONE"
+	
+	
 fi
 
 ### DOCTESTS ###

pandas/tests/io/excel/test_openpyxl.py

@@ -8,6 +8,7 @@
 import pandas._testing as tm
 
 from pandas.io.excel import ExcelWriter, _OpenpyxlWriter
+from pandas.testing import ensure_clean
 
 openpyxl = pytest.importorskip("openpyxl")
 
@@ -120,4 +121,4 @@ def test_to_excel_with_openpyxl_engine(ext, tmpdir):
     styled.to_excel(filename, engine="openpyxl")
 
     assert filename.exists()
-    os.remove(filename)
+    ensure_clean(filename)

pandas/tests/io/excel/test_writers.py

@@ -901,7 +901,7 @@ def test_to_excel_unicode_filename(self, ext, path):
     #             assert 1 == cell_xf.border.bottom_line_style
     #             assert 1 == cell_xf.border.left_line_style
     #             assert 2 == cell_xf.alignment.hor_align
-    #     os.remove(filename)
+    #     ensure_clean(filename)
     # def test_to_excel_header_styling_xlsx(self, engine, ext):
     #     import StringIO
     #     s = StringIO(
@@ -953,7 +953,7 @@ def test_to_excel_unicode_filename(self, ext, path):
     #     mergedcells_addrs = ["C1", "E1", "G1"]
     #     for maddr in mergedcells_addrs:
     #         assert ws.cell(maddr).merged
-    #     os.remove(filename)
+    #     ensure_clean(filename)
 
     @pytest.mark.parametrize("use_headers", [True, False])
     @pytest.mark.parametrize("r_idx_nlevels", [1, 2, 3])

pandas/tests/io/pytables/common.py

@@ -5,6 +5,7 @@
 import pytest
 
 from pandas.io.pytables import HDFStore
+from pandas.testing import ensure_clean
 
 tables = pytest.importorskip("tables")
 # set these parameters so we don't have file sharing
@@ -16,7 +17,7 @@
 def safe_remove(path):
     if path is not None:
         try:
-            os.remove(path)
+            ensure_clean(path)
         except OSError:
             pass