rename function and give the right number of parameters

Author: jgfoster

exe/arduino_ci.rb

@@ -447,7 +447,7 @@ def perform_unit_tests(cpp_library, file_config)
 
 def build_shared_library(gcc_binary, platform, config, cpp_library)
   attempt_multiline("Build shared library with #{gcc_binary} for #{platform}") do
-    exe = cpp_library.build_share_library_with_configuration(
+    exe = cpp_library.build_shared_library(
       config.aux_libraries_for_unittest,
       gcc_binary,
       config.gcc_config(platform)

lib/arduino_ci/cpp_library.rb

@@ -519,7 +519,7 @@ def build_for_test(test_file, gcc_binary)
     # @param gcc_binary [String] name of a compiler
     # @param ci_gcc_config [Hash] The GCC config object
     # @return [Pathname] path to the compiled test executable
-    def build_share_library_with_configuration(aux_libraries, gcc_binary, ci_gcc_config)
+    def build_shared_library(aux_libraries, gcc_binary, ci_gcc_config)
       Dir.mkdir BUILD_DIR unless File.exist?(BUILD_DIR)
       if OS.windows?
         flag = ENV["PATH"].include? ";"

spec/cpp_library_spec.rb

@@ -45,7 +45,7 @@ def verified_install(backend, path)
         config       = ArduinoCI::CIConfig.default.from_example(cpp_lib_path)
         path         = config.allowable_unittest_files(@cpp_library.test_files).first
         compiler     = config.compilers_to_use.first
-        result       = @cpp_library.build_shared_library(path, [], compiler, config.gcc_config("uno"))
+        result       = @cpp_library.build_shared_library([], compiler, config.gcc_config("uno"))
         expect(result).to be nil
         result       = @cpp_library.build_for_test(path, compiler)
         expect(result).to be nil
@@ -275,7 +275,7 @@ def verified_install(backend, path)
       expected = path.basename.to_s.include?("good")
       config.compilers_to_use.each do |compiler|
         it "tests #{File.basename(path)} with #{compiler} expecting #{expected}" do
-          exe = @cpp_library.build_shared_library(path, [], compiler, config.gcc_config("uno"))
+          exe = @cpp_library.build_shared_library([], compiler, config.gcc_config("uno"))
           expect(exe).not_to be nil
           exe = @cpp_library.build_for_test(path, compiler)
           expect(exe).not_to be nil

spec/testsomething_unittests_spec.rb

@@ -74,7 +74,7 @@
 
           before(:each) do
             @cpp_library = backend.install_local_library(cpp_lib_path)
-            @cpp.library.build_shared_library(path, [], compiler, config.gcc_config("uno"))
+            @cpp.library.build_shared_library([], compiler, config.gcc_config("uno"))
             @exe = @cpp_library.build_for_test(path, compiler)
           end