Implement -min-length, closes #2

Author: Jonathan Gautheron

README.md

@@ -25,7 +25,8 @@ Flags:
   -ignore            exclude files matching the given regular expression
   -ignore-tests      exclude tests from the search (default: true)
   -min-occurrences   report from how many occurrences (default: 2)
-  -match-constant    look for existing constants matching the strings
+  -min-length        only report strings with the minimum given length (default: 3)
+  -match-constant    look for existing constants matching the values
   -numbers           search also for duplicated numbers
   -min          	   minimum value, only works with -numbers
   -max          	   maximum value, only works with -numbers

cmd/goconst/main.go

@@ -23,6 +23,7 @@ Flags:
   -ignore            exclude files matching the given regular expression
   -ignore-tests      exclude tests from the search (default: true)
   -min-occurrences   report from how many occurrences (default: 2)
+  -min-length        only report strings with the minimum given length (default: 3)
   -match-constant    look for existing constants matching the strings
   -numbers           search also for duplicated numbers
   -min          	   minimum value, only works with -numbers
@@ -41,6 +42,7 @@ var (
 	flagIgnore         = flag.String("ignore", "", "ignore files matching the given regular expression")
 	flagIgnoreTests    = flag.Bool("ignore-tests", true, "exclude tests from the search")
 	flagMinOccurrences = flag.Int("min-occurrences", 2, "report from how many occurrences")
+	flagMinLength      = flag.Int("min-length", 3, "only report strings with the minimum given length")
 	flagMatchConstant  = flag.Bool("match-constant", false, "look for existing constants matching the strings")
 	flagNumbers        = flag.Bool("numbers", false, "search also for duplicated numbers")
 	flagMin            = flag.Int("min", 0, "minimum value, only works with -numbers")
@@ -67,6 +69,7 @@ func main() {
 		*flagIgnoreTests,
 		*flagMatchConstant,
 		*flagNumbers,
+		*flagMinLength,
 	)
 	strs, consts, err := gco.ParseTree()
 	if err != nil {

parser.go

@@ -25,6 +25,7 @@ type Parser struct {
 	// Meant to be passed via New()
 	path, ignore               string
 	ignoreTests, matchConstant bool
+	minLength                  int
 
 	supportedTokens []token.Token
 
@@ -35,7 +36,7 @@ type Parser struct {
 
 // New creates a new instance of the parser.
 // This is your entry point if you'd like to use goconst as an API.
-func New(path, ignore string, ignoreTests, matchConstant, numbers bool) *Parser {
+func New(path, ignore string, ignoreTests, matchConstant, numbers bool, minLength int) *Parser {
 	supportedTokens := []token.Token{token.STRING}
 	if numbers {
 		supportedTokens = append(supportedTokens, token.INT, token.FLOAT)
@@ -46,6 +47,7 @@ func New(path, ignore string, ignoreTests, matchConstant, numbers bool) *Parser
 		ignore:          ignore,
 		ignoreTests:     ignoreTests,
 		matchConstant:   matchConstant,
+		minLength:       minLength,
 		supportedTokens: supportedTokens,
 
 		// Initialize the maps

visitor.go

@@ -109,6 +109,10 @@ func (v *treeVisitor) addString(str string, pos token.Pos) {
 		return
 	}
 
+	if len(str) < v.p.minLength {
+		return
+	}
+
 	_, ok := v.p.strs[str]
 	if !ok {
 		v.p.strs[str] = make([]ExtendedPos, 0)