Fix possible string overflow in BTAdvertisedDeviceSet::toString()

me-no-dev · me-no-dev · commit 57cf2fb9f578 · 2021-04-16T18:51:01.000+03:00
diff --git a/libraries/BluetoothSerial/src/BTAdvertisedDeviceSet.cpp b/libraries/BluetoothSerial/src/BTAdvertisedDeviceSet.cpp
@@ -47,8 +47,8 @@ std::string BTAdvertisedDeviceSet::toString() {
 		res += val;
 	}
 	if (haveRSSI()) {
-		char val[4];
-		snprintf(val, sizeof(val), "%d", getRSSI());
+		char val[6];
+		snprintf(val, sizeof(val), "%d", (int8_t)getRSSI());
 		res += ", rssi: ";
 		res += val;
 	}

Original file line number	Diff line number	Diff line change
`@@ -47,8 +47,8 @@ std::string BTAdvertisedDeviceSet::toString() {`
`47`	`47`	`res += val;`
`48`	`48`	`}`
`49`	`49`	`if (haveRSSI()) {`
`50`		`- char val[4];`
`51`		`- snprintf(val, sizeof(val), "%d", getRSSI());`
	`50`	`+ char val[6];`
	`51`	`+ snprintf(val, sizeof(val), "%d", (int8_t)getRSSI());`
`52`	`52`	`res += ", rssi: ";`
`53`	`53`	`res += val;`
`54`	`54`	`}`