Fixes #7935 - Review HTTP/2 error handling (#8048)

sbordet · web-flow · commit 513a2cb2562f · 2022-05-23T16:12:24.000+02:00
Fixed HTTP/3 in similar way as HTTP/2.

Signed-off-by: Simone Bordet &lt;simone.bordet@gmail.com&gt;
diff --git a/jetty-http3/http3-server/src/main/java/org/eclipse/jetty/http3/server/internal/HttpChannelOverHTTP3.java b/jetty-http3/http3-server/src/main/java/org/eclipse/jetty/http3/server/internal/HttpChannelOverHTTP3.java
@@ -161,13 +161,11 @@ public Runnable onRequest(HeadersFrame frame)
         {
             if (LOG.isDebugEnabled())
                 LOG.debug("onRequest() failure", x);
-            onBadMessage(x);
-            return null;
+            return () -> onBadMessage(x);
         }
         catch (Throwable x)
         {
-            onBadMessage(new BadMessageException(HttpStatus.INTERNAL_SERVER_ERROR_500, null, x));
-            return null;
+            return () -> onBadMessage(new BadMessageException(HttpStatus.INTERNAL_SERVER_ERROR_500, null, x));
         }
     }
 

Original file line number	Diff line number	Diff line change
`@@ -161,13 +161,11 @@ public Runnable onRequest(HeadersFrame frame)`
`161`	`161`	`{`
`162`	`162`	`if (LOG.isDebugEnabled())`
`163`	`163`	`LOG.debug("onRequest() failure", x);`
`164`		`- onBadMessage(x);`
`165`		`- return null;`
	`164`	`+ return () -> onBadMessage(x);`
`166`	`165`	`}`
`167`	`166`	`catch (Throwable x)`
`168`	`167`	`{`
`169`		`- onBadMessage(new BadMessageException(HttpStatus.INTERNAL_SERVER_ERROR_500, null, x));`
`170`		`- return null;`
	`168`	`+ return () -> onBadMessage(new BadMessageException(HttpStatus.INTERNAL_SERVER_ERROR_500, null, x));`
`171`	`169`	`}`
`172`	`170`	`}`
`173`	`171`