Skip to content

Add extra e2e test that exercises some other features #63

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jeroenheijmans opened this issue Sep 26, 2020 · 1 comment
Open

Add extra e2e test that exercises some other features #63

jeroenheijmans opened this issue Sep 26, 2020 · 1 comment
Labels
up-for-grabs Good for newcomers

Comments

@jeroenheijmans
Copy link
Owner

jeroenheijmans commented Sep 26, 2020

The current basic e2e test just boots up the app. The happy-path-flow e2e test will log the user in and out via the login button. This leaves a few components unused in e2e tests:

  • The auth-guard.service.ts (so being prevented from going to a protected page)
  • The auth-guard-with-forced-login.service.ts (so getting sent off to IDS4 when you go to a protected page)
  • The should-login.component.ts page
  • and maybe a handful of others too

Let's add 1 more e2e test that tests an extra typical "flow" exercising the above parts.

Note that npm run e2e should run the tests, and these are also run for a PR via GitHub Actions (and nightly for master).

@jeroenheijmans
Copy link
Owner Author

It would still be a nice (albeit low-prio) addition to have this, but I've removed hacktoberfest since the repo won't participate in the event per-say.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
up-for-grabs Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant