Skip to content

Commit fe5cc59

Browse files
Change "BASIC" to "Basic"
After further discussion and research in manfredsteyer#368 I noticed that even though RFC 7617 seems to state that: > Note that both scheme and parameter names are matched > case-insensitively. All the examples use "Basic" instead of "BASIC". There is one very notable framework that checks case *sensitively* for "Basic". Given that the header was incorrect anyways, we can be sure that changing this casing won't further break anything, and work around issues for server side frameworks like Spring. See: https://tools.ietf.org/html/rfc7617 See: https://github.com/spring-projects/spring-security/blob/5.0.6.RELEASE/web/src/main/java/org/springframework/security/web/authentication/www/BasicAuthenticationFilter.java#L157 Fixes manfredsteyer#368
1 parent 3da25e1 commit fe5cc59

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

projects/lib/src/oauth-service.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -639,7 +639,7 @@ export class OAuthService extends AuthConfig {
639639
const header = btoa(`${this.clientId}:${this.dummyClientSecret}`);
640640
headers = headers.set(
641641
'Authorization',
642-
'BASIC ' + header);
642+
'Basic ' + header);
643643
}
644644

645645
if (!this.useHttpBasicAuthForPasswordFlow) {

0 commit comments

Comments
 (0)