Merge pull request pandas-dev#8454 from jreback/legacy_pickle

BUG: reset identity on legacy index pickles (GH8431)

Author: jreback

pandas/core/index.py

@@ -843,6 +843,7 @@ def __setstate__(self, state):
                 np.ndarray.__setstate__(data, state)
 
             self._data = data
+            self._reset_identity()
         else:
             raise Exception("invalid pickle state")
     _unpickle_compat = __setstate__
@@ -3349,6 +3350,7 @@ def __setstate__(self, state):
         self._set_names(names)
         self.sortorder = sortorder
         self._verify_integrity()
+        self._reset_identity()
 
     def __getitem__(self, key):
         if np.isscalar(key):

pandas/tests/data/s1-0.12.0.pkl

@@ -270,6 +270,15 @@ def test_view(self):
         i_view = i.view()
         self.assertEqual(i_view.name, 'Foo')
 
+    def test_legacy_pickle_identity(self):
+
+        # GH 8431
+        pth = tm.get_data_path()
+        s1 = pd.read_pickle(os.path.join(pth,'s1-0.12.0.pkl'))
+        s2 = pd.read_pickle(os.path.join(pth,'s2-0.12.0.pkl'))
+        self.assertFalse(s1.index.identical(s2.index))
+        self.assertFalse(s1.index.equals(s2.index))
+
     def test_astype(self):
         casted = self.intIndex.astype('i8')
 
@@ -532,7 +541,7 @@ def test_intersection(self):
         result3 = idx1.intersection(idx3)
         self.assertTrue(tm.equalContents(result3, expected3))
         self.assertEqual(result3.name, expected3.name)
-        
+
         # non-monotonic non-unique
         idx1 = Index(['A','B','A','C'])
         idx2 = Index(['B','D'])

pandas/tests/data/s2-0.12.0.pkl

@@ -630,6 +630,7 @@ def __setstate__(self, state):
                 np.ndarray.__setstate__(data, state)
 
             self._data = data
+            self._reset_identity()
 
         else:
             raise Exception("invalid pickle state")