CLN: remove no-longer-used 'kind' keyword

Author: jbrockmendel

pandas/core/indexes/base.py

@@ -5587,7 +5587,7 @@ def _validate_indexer(self, form: str_t, key, kind: str_t):
         if key is not None and not is_integer(key):
             raise self._invalid_indexer(form, key)
 
-    def _maybe_cast_slice_bound(self, label, side: str_t, kind):
+    def _maybe_cast_slice_bound(self, label, side: str_t):
         """
         This function should be overloaded in subclasses that allow non-trivial
         casting on label-slice bounds, e.g. datetime-like indices allowing
@@ -5597,7 +5597,6 @@ def _maybe_cast_slice_bound(self, label, side: str_t, kind):
         ----------
         label : object
         side : {'left', 'right'}
-        kind : {'loc', 'getitem'} or None
 
         Returns
         -------
@@ -5607,7 +5606,6 @@ def _maybe_cast_slice_bound(self, label, side: str_t, kind):
         -----
         Value of `side` parameter should be validated in caller.
         """
-        assert kind in ["loc", "getitem", None]
 
         # We are a plain index here (sub-class override this method if they
         # wish to have special treatment for floats/ints, e.g. Float64Index and
@@ -5662,7 +5660,7 @@ def get_slice_bound(self, label, side: str_t, kind) -> int:
 
         # For datetime indices label may be a string that has to be converted
         # to datetime boundary according to its resolution.
-        label = self._maybe_cast_slice_bound(label, side, kind)
+        label = self._maybe_cast_slice_bound(label, side)
 
         # we need to look up the label
         try:

pandas/core/indexes/datetimes.py

@@ -720,15 +720,14 @@ def _maybe_cast_for_get_loc(self, key) -> Timestamp:
             key = key.tz_convert(self.tz)
         return key
 
-    def _maybe_cast_slice_bound(self, label, side: str, kind):
+    def _maybe_cast_slice_bound(self, label, side: str):
         """
         If label is a string, cast it to datetime according to resolution.
 
         Parameters
         ----------
         label : object
         side : {'left', 'right'}
-        kind : {'loc', 'getitem'} or None
 
         Returns
         -------
@@ -738,7 +737,6 @@ def _maybe_cast_slice_bound(self, label, side: str, kind):
         -----
         Value of `side` parameter should be validated in caller.
         """
-        assert kind in ["loc", "getitem", None]
 
         if isinstance(label, str):
             freq = getattr(self, "freqstr", getattr(self, "inferred_freq", None))
@@ -819,12 +817,12 @@ def check_str_or_none(point):
         mask = np.array(True)
         deprecation_mask = np.array(True)
         if start is not None:
-            start_casted = self._maybe_cast_slice_bound(start, "left", kind)
+            start_casted = self._maybe_cast_slice_bound(start, "left")
             mask = start_casted <= self
             deprecation_mask = start_casted == self
 
         if end is not None:
-            end_casted = self._maybe_cast_slice_bound(end, "right", kind)
+            end_casted = self._maybe_cast_slice_bound(end, "right")
             mask = (self <= end_casted) & mask
             deprecation_mask = (end_casted == self) | deprecation_mask
 

pandas/core/indexes/interval.py

@@ -802,8 +802,8 @@ def _should_fallback_to_positional(self) -> bool:
         #  positional in this case
         return self.dtype.subtype.kind in ["m", "M"]
 
-    def _maybe_cast_slice_bound(self, label, side: str, kind):
-        return getattr(self, side)._maybe_cast_slice_bound(label, side, kind)
+    def _maybe_cast_slice_bound(self, label, side: str):
+        return getattr(self, side)._maybe_cast_slice_bound(label, side)
 
     @Appender(Index._convert_list_indexer.__doc__)
     def _convert_list_indexer(self, keyarr):

pandas/core/indexes/numeric.py

@@ -114,8 +114,7 @@ def _validate_dtype(cls, dtype: Dtype) -> None:
     # Indexing Methods
 
     @doc(Index._maybe_cast_slice_bound)
-    def _maybe_cast_slice_bound(self, label, side: str, kind):
-        assert kind in ["loc", "getitem", None]
+    def _maybe_cast_slice_bound(self, label, side: str):
 
         # we will try to coerce to integers
         return self._maybe_cast_indexer(label)

pandas/core/indexes/period.py

@@ -530,7 +530,7 @@ def get_loc(self, key, method=None, tolerance=None):
         except KeyError as err:
             raise KeyError(orig_key) from err
 
-    def _maybe_cast_slice_bound(self, label, side: str, kind: str):
+    def _maybe_cast_slice_bound(self, label, side: str):
         """
         If label is a string or a datetime, cast it to Period.ordinal according
         to resolution.
@@ -539,7 +539,6 @@ def _maybe_cast_slice_bound(self, label, side: str, kind: str):
         ----------
         label : object
         side : {'left', 'right'}
-        kind : {'loc', 'getitem'}
 
         Returns
         -------
@@ -548,9 +547,7 @@ def _maybe_cast_slice_bound(self, label, side: str, kind: str):
         Notes
         -----
         Value of `side` parameter should be validated in caller.
-
         """
-        assert kind in ["loc", "getitem"]
 
         if isinstance(label, datetime):
             return Period(label, freq=self.freq)

pandas/core/indexes/timedeltas.py

@@ -192,22 +192,19 @@ def get_loc(self, key, method=None, tolerance=None):
 
         return Index.get_loc(self, key, method, tolerance)
 
-    def _maybe_cast_slice_bound(self, label, side: str, kind):
+    def _maybe_cast_slice_bound(self, label, side: str):
         """
         If label is a string, cast it to timedelta according to resolution.
 
         Parameters
         ----------
         label : object
         side : {'left', 'right'}
-        kind : {'loc', 'getitem'} or None
 
         Returns
         -------
         label : object
         """
-        assert kind in ["loc", "getitem", None]
-
         if isinstance(label, str):
             parsed = Timedelta(label)
             lbound = parsed.round(parsed.resolution_string)

pandas/tests/indexes/datetimes/test_indexing.py

@@ -679,18 +679,18 @@ def test_maybe_cast_slice_bounds_empty(self):
         # GH#14354
         empty_idx = date_range(freq="1H", periods=0, end="2015")
 
-        right = empty_idx._maybe_cast_slice_bound("2015-01-02", "right", "loc")
+        right = empty_idx._maybe_cast_slice_bound("2015-01-02", "right")
         exp = Timestamp("2015-01-02 23:59:59.999999999")
         assert right == exp
 
-        left = empty_idx._maybe_cast_slice_bound("2015-01-02", "left", "loc")
+        left = empty_idx._maybe_cast_slice_bound("2015-01-02", "left")
         exp = Timestamp("2015-01-02 00:00:00")
         assert left == exp
 
     def test_maybe_cast_slice_duplicate_monotonic(self):
         # https://github.com/pandas-dev/pandas/issues/16515
         idx = DatetimeIndex(["2017", "2017"])
-        result = idx._maybe_cast_slice_bound("2017-01-01", "left", "loc")
+        result = idx._maybe_cast_slice_bound("2017-01-01", "left")
         expected = Timestamp("2017-01-01")
         assert result == expected
 

pandas/tests/indexes/period/test_partial_slicing.py

@@ -110,7 +110,7 @@ def test_maybe_cast_slice_bound(self, make_range, frame_or_series):
 
         # Check the lower-level calls are raising where expected.
         with pytest.raises(TypeError, match=msg):
-            idx._maybe_cast_slice_bound("foo", "left", "loc")
+            idx._maybe_cast_slice_bound("foo", "left")
         with pytest.raises(TypeError, match=msg):
             idx.get_slice_bound("foo", "left", "loc")