Small updates

Author: TomAugspurger

pandas/core/arrays/datetimelike.py

@@ -427,7 +427,7 @@ def _ndarray_values(self):
         return self._data
 
     # ------------------------------------------------------------------
-    # Formatting
+    # Rendering Methods
 
     def _format_native_types(self, na_rep=u'NaT', date_format=None):
         """
@@ -615,7 +615,7 @@ def fillna(self, value=None, method=None, limit=None):
         return new_values
 
     def astype(self, dtype, copy=True):
-        # Some notes on cases we don't have to handle:
+        # Some notes on cases we don't have to handle here in the base class:
         #   1. PeriodArray.astype handles period -> period
         #   2. DatetimeArray.astype handles conversion between tz.
         #   3. DatetimeArray.astype handles datetime -> period
@@ -626,9 +626,9 @@ def astype(self, dtype, copy=True):
             return self._box_values(self.asi8)
         elif is_string_dtype(dtype) and not is_categorical_dtype(dtype):
             return self._format_native_types()
-            # return Index(self.format(), name=self.name, dtype=object)
         elif is_integer_dtype(dtype):
             # we deliberately ignore int32 vs. int64 here.
+            # See https://github.com/pandas-dev/pandas/issues/24381 for more.
             values = self.asi8
             if copy:
                 values = values.copy()

pandas/core/arrays/datetimes.py

@@ -573,7 +573,8 @@ def _validate_fill_value(self, fill_value):
         return fill_value
 
     # -----------------------------------------------------------------
-    # Formatting Methods
+    # Rendering Methods
+
     def _format_native_types(self, na_rep=u'NaT', date_format=None, **kwargs):
         from pandas.io.formats.format import _get_format_datetime64_from_values
         format = _get_format_datetime64_from_values(self, date_format)

pandas/core/arrays/timedeltas.py

@@ -281,9 +281,6 @@ def _maybe_clear_freq(self):
 
     # ----------------------------------------------------------------
     # Array-Like / EA-Interface Methods
-    def _formatter(self, boxed=False):
-        from pandas.io.formats.format import _get_format_timedelta64
-        return _get_format_timedelta64(self, box=True)
 
     def __array__(self, dtype=None):
         # TODO(https://github.com/pandas-dev/pandas/pull/23593)
@@ -306,6 +303,16 @@ def _validate_fill_value(self, fill_value):
                              "Got '{got}'.".format(got=fill_value))
         return fill_value
 
+    # -----------------------------------------------------------------
+    # Rendering Methods
+
+    def _format_native_types(self):
+        return self.astype(object)
+
+    def _formatter(self, boxed=False):
+        from pandas.io.formats.format import _get_format_timedelta64
+        return _get_format_timedelta64(self, box=True)
+
     # ----------------------------------------------------------------
     # Arithmetic Methods
 
@@ -775,9 +782,6 @@ def astype(self, dtype, copy=True):
             return self
         return super(TimedeltaArrayMixin, self).astype(dtype, copy=copy)
 
-    def _format_native_types(self):
-        return self.astype(object)
-
     days = _field_accessor("days", "days",
                            "Number of days for each element.")
     seconds = _field_accessor("seconds", "seconds",