SSH/Gitolite server host on 1.2

[madorin]

Hello,

After successful upgrade to 1.2, pressing in Config [Apply] button it says that "SSH/Gitolite server host" is invalid (it is set to default value as "localhost"). Setting it to 127.0.0.1, config was accepted.
It seems that it accepts IPs only, strange. Tried with different values, IPs and hostnames.

Thanks!

[dgeo]

Same here: I looked in the code, and it MUST be an IP(v4) address. Dunno if the code have to be changed here (I'd prefer) to accept hostnames, or if admin interface should precise 'SSH/Gitolite server IP(v4)' …
My 2 cts…

[n-rodriguez]

Same here: I looked in the code, and it MUST be an IP(v4) address. Dunno if the code have to be changed here (I'd prefer) to accept hostnames, or if admin interface should precise 'SSH/Gitolite server IP(v4)' …

Yep. I chose to fill the field with an IP because of :

• validation (easier to valid an IP adress than a domain name)
• there is no vhost concept in SSH so domain is useless (except for DNS update, but you don't move your Gitolite server every day ;)).

[madorin]

I think it should accept host names beside of IPs.
It give more flexibility, especially on changes, migrations.
SSH connect functions require "host" parameter. It can be an IP or a NAME.
Why limit it just to IPv4? v6 is much closer than it looks ;)
Best "validation" is trying to connect to user specified host, instead of just validating IP.

[n-rodriguez]

I think it should accept host names beside of IPs.

Well this sounds difficult as '12345.36.70.fr' is a valid hostname and an invalid IPv4 or IPv6.
I think I'm gonna rollback to hostname and only hostname.