Skip to content

Support for JSON Schema v5 (draft Wright 00) #226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tfesenko opened this issue Apr 5, 2017 · 7 comments
Open

Support for JSON Schema v5 (draft Wright 00) #226

tfesenko opened this issue Apr 5, 2017 · 7 comments

Comments

@tfesenko
Copy link

tfesenko commented Apr 5, 2017

JSON Schema v5 (draft Wright 00) is the current version of JSON Schema specification:
JSON Schema Core and Json Schema Validation

According to their wiki page:

Draft 5 was primarily a cleanup of Draft 4 and therefore does not have its own meta-schema. The Draft 4 meta-schema should continue to be used until Draft 6, which will have a new meta-schema, is available.

Does JSON Schema Validator officially support JSON Schema Draft 5 aka Wright 00? I assume so. If so, it would be helpful to update the project page.

@huggsboson
Copy link
Member

Would love to accept a pull request on this.

@huggsboson
Copy link
Member

Issue #231 seems to be an issue related to a change between Draft 4 and Draft 5. It'd be good to get a diff between the two drafts and add a test suite and fixes for draft 5.

@johnjiang
Copy link

johnjiang commented Oct 27, 2017

Implementors should not implement or advertise support for “draft-05”.

http://json-schema.org/draft-06/json-schema-migration-faq.html#q-what-happened-to-draft-05

We should change the issue title to be "Support for JSON Schema v6"

@handrews
Copy link

draft-07 is now out (it is backwards-compatible with draft-06, so if you implement draft-07 then supporting draft-06 as well should be pretty trivial):

http://json-schema.org/specification.html

Note that while the breaking changes to core/validation between draft-04 and draft-06 are fairly minimal, Hyper-Schema has changed substantially.

@elreydetodo
Copy link

Does anyone have a sense of what the code changes would be to support the newer drafts? I might be willing to try a pull request for supporting at least one or two newer versions if I can get a sense of what code changes are needed. I'm already pretty familiar with the drafts and the changes, I just don't know how that translates into code changes in this module.

@huggsboson
Copy link
Member

I don't have a good sense. It seems like having a good conformance suite in place either ahead of or concurrent with the change would be a good way to drive it forward. I'd also love to look into whoever steps up to the plate on this a owner/co-owner of the project, as this project has been under owned since fge departed.

@handrews
Copy link

having a good conformance suite in place either ahead of or concurrent with the change

https://github.com/json-schema-org/JSON-Schema-Test-Suite

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants