Skip to content

Commit 9a8edf2

Browse files
committed
Don't log "Jasmine worker not sending...after disconnect" messages
These haven't proven useful and they can cause serious flooding e.g when the runner terminates execution while a worker is processing a suite with a lot of fast specs.
1 parent 22271c7 commit 9a8edf2

File tree

2 files changed

+0
-13
lines changed

2 files changed

+0
-13
lines changed

lib/parallel_worker.js

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -121,9 +121,6 @@ class ParallelWorker {
121121
await env.execute();
122122

123123
if (!this.clusterWorker_.isConnected()) {
124-
console.error(
125-
'Jasmine worker not sending specFileDone message after disconnect'
126-
);
127124
return;
128125
}
129126

@@ -153,10 +150,6 @@ function forwardingReporter(clusterWorker) {
153150
for (const eventName of eventNames) {
154151
reporter[eventName] = function (payload) {
155152
if (!clusterWorker.isConnected()) {
156-
console.error(
157-
`Jasmine worker not sending ${eventName} reporter event ` +
158-
'after disconnect'
159-
);
160153
return;
161154
}
162155

spec/parallel_worker_spec.js

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -537,9 +537,6 @@ describe('ParallelWorker', function() {
537537
await Promise.resolve();
538538
// No other messages should have been sent
539539
expect(this.clusterWorker.send).toHaveBeenCalledOnceWith({type: 'booted'});
540-
expect(console.error).toHaveBeenCalledOnceWith(
541-
'Jasmine worker not sending specFileDone message after disconnect'
542-
);
543540
});
544541
});
545542

@@ -591,9 +588,6 @@ describe('ParallelWorker', function() {
591588
dispatchRepoterEvent(env, eventName, payload);
592589

593590
expect(this.clusterWorker.send).not.toHaveBeenCalled();
594-
expect(console.error).toHaveBeenCalledOnceWith(
595-
`Jasmine worker not sending ${eventName} reporter event after disconnect`
596-
);
597591
});
598592
}
599593

0 commit comments

Comments
 (0)