Skip to content

Commit 1e133d6

Browse files
committed
Updated 4.0 release notes to reflect jsLoader: "import" breaking jsx
See #188
1 parent da977b8 commit 1e133d6

File tree

1 file changed

+11
-13
lines changed

1 file changed

+11
-13
lines changed

release_notes/4.0.0.md

Lines changed: 11 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,15 @@ as well.
2626
[API reference](https://jasmine.github.io/api/npm/4.0/Jasmine) is considered
2727
a private API.
2828

29+
* ES module support is enabled by default, but can still be disabled by
30+
adding `jsLoader: "require"` to the configuration. `jsLoader: "import"` is
31+
now a no-op.
32+
33+
This change breaks loading of files with extensions that aren't supported by
34+
dynamic `import()`, such as `.jsx`. If you have specs or source files with
35+
such extensions, you can either rename the files to `.js` or add
36+
`jsLoader: "require"` to your Jasmine config file.
37+
2938
* Config files can be ES modules. This is a breaking change because it requires
3039
`Jasmine#loadConfigFile` to be async.
3140

@@ -57,20 +66,9 @@ as well.
5766

5867
## New features and bugfixes
5968

60-
* Full support for ES modules in the default configuration:
61-
* ES module support is enabled by default, but can still be disabled by
62-
adding `jsLoader: "require"` to the configuration. `jsLoader: "import"` is
63-
now a no-op.
64-
65-
We think it's highly unlikely that this change will break anything. If it
66-
does (i.e. your code works with `jsLoader: "require"` but not without it),
67-
please [let us know](https://github.com/jasmine/jasmine-npm/issues/new).
68-
This will help us understand whether the `jsLoader` config property is still
69-
needed.
70-
71-
* Files listed in the `requires` config property can be ES modules
69+
* Files listed in the `requires` config property can be ES modules
7270

73-
* Reporters specified with `--reporter=` can be ES modules.
71+
* Reporters specified with `--reporter=` can be ES modules.
7472

7573
* Allow use without creating globals.
7674
* See <https://jasmine.github.io/api/npm/4.0/JasmineOptions.html#globals>.

0 commit comments

Comments
 (0)