Skip to content

Commit 0fc3a2d

Browse files
committed
Parallel: take care of pending specs
1 parent 2d8ff6c commit 0fc3a2d

File tree

3 files changed

+25
-11
lines changed

3 files changed

+25
-11
lines changed

spec/command_spec.js

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -502,10 +502,6 @@ describe('command', function() {
502502
});
503503

504504
sharedRunBehavior('--parallel=2');
505-
506-
it('does not allow the random seed to be set');
507-
508-
it('does not allow randomization to be disabled');
509505
});
510506
});
511507

spec/parallel_runner_spec.js

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -370,9 +370,6 @@ describe('ParallelRunner', function() {
370370
});
371371
});
372372

373-
it('handles worker crashes');
374-
it('handles worker exec failures');
375-
376373
it('dispatches a jasmineStarted event at the start of execution', async function () {
377374
this.testJasmine.numWorkers = 2;
378375
this.testJasmine.loadConfig({

spec/parallel_worker_spec.js

Lines changed: 25 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -93,7 +93,31 @@ describe('ParallelWorker', function() {
9393
expect(core.boot).toHaveBeenCalledWith(jasmine.is(core));
9494
});
9595

96-
it('does something reasonable when the core module fails to load');
96+
it('sends a fatalError message when the core module fails to load', async function() {
97+
const error = new Error('core loading failed');
98+
const loader = {
99+
load() {
100+
return Promise.reject(error);
101+
}
102+
};
103+
new ParallelWorker({loader, clusterWorker: this.clusterWorker});
104+
105+
this.clusterWorker.emit('message', {
106+
type: 'configure',
107+
configuration: {}
108+
});
109+
await new Promise(res => setTimeout(res));
110+
111+
expect(this.clusterWorker.send).toHaveBeenCalledWith(
112+
{
113+
type: 'fatalError',
114+
error: {
115+
message: error.message,
116+
stack: error.stack
117+
},
118+
}
119+
);
120+
});
97121

98122
it('creates and configures an env', async function() {
99123
const env = jasmine.createSpyObj('env', [
@@ -555,9 +579,6 @@ describe('ParallelWorker', function() {
555579
});
556580
}
557581
});
558-
559-
560-
it('exits on disconnect');
561582
});
562583

563584
function dispatchRepoterEvent(env, eventName, payload) {

0 commit comments

Comments
 (0)