update recommended rules to match style guide

Author: chrisvfritz

.gitignore

@@ -3,3 +3,4 @@
 /tests/integrations/*/node_modules
 /node_modules
 /test.*
+yarn.lock

README.md

@@ -92,15 +92,15 @@ The `--fix` option on the command line automatically fixes problems reported by
 
 |    | Rule ID | Description |
 |:---|:--------|:------------|
-|  | [no-dupe-keys](./docs/rules/no-dupe-keys.md) | disallow duplication of field names |
+| :white_check_mark: | [no-dupe-keys](./docs/rules/no-dupe-keys.md) | disallow duplication of field names |
 | :white_check_mark: | [no-parsing-error](./docs/rules/no-parsing-error.md) | disallow parsing errors in `<template>` |
-|  | [no-reserved-keys](./docs/rules/no-reserved-keys.md) | disallow overwriting reserved keys |
-|  | [no-shared-component-data](./docs/rules/no-shared-component-data.md) | enforce component's data property to be a function |
-|  | [no-template-key](./docs/rules/no-template-key.md) | disallow `key` attribute on `<template>` |
+| :white_check_mark: | [no-reserved-keys](./docs/rules/no-reserved-keys.md) | disallow overwriting reserved keys |
+| :white_check_mark: | [no-shared-component-data](./docs/rules/no-shared-component-data.md) | enforce component's data property to be a function |
+| :white_check_mark: | [no-template-key](./docs/rules/no-template-key.md) | disallow `key` attribute on `<template>` |
 |  | [no-unused-vars](./docs/rules/no-unused-vars.md) | disallow unused variable definitions of v-for directives or scope attributes |
-|  | [require-render-return](./docs/rules/require-render-return.md) | enforce render function to always return value |
-|  | [require-valid-default-prop](./docs/rules/require-valid-default-prop.md) | enforce props default values to be valid |
-|  | [return-in-computed-property](./docs/rules/return-in-computed-property.md) | enforce that a return statement is present in computed property |
+| :white_check_mark: | [require-render-return](./docs/rules/require-render-return.md) | enforce render function to always return value |
+| :white_check_mark: | [require-valid-default-prop](./docs/rules/require-valid-default-prop.md) | enforce props default values to be valid |
+| :white_check_mark: | [return-in-computed-property](./docs/rules/return-in-computed-property.md) | enforce that a return statement is present in computed property |
 | :white_check_mark: | [valid-template-root](./docs/rules/valid-template-root.md) | enforce valid template root |
 | :white_check_mark: | [valid-v-bind](./docs/rules/valid-v-bind.md) | enforce valid `v-bind` directives |
 | :white_check_mark: | [valid-v-cloak](./docs/rules/valid-v-cloak.md) | enforce valid `v-cloak` directives |
@@ -121,34 +121,34 @@ The `--fix` option on the command line automatically fixes problems reported by
 
 |    | Rule ID | Description |
 |:---|:--------|:------------|
-| :wrench: | [html-end-tags](./docs/rules/html-end-tags.md) | enforce end tag style |
-|  | [no-async-in-computed-properties](./docs/rules/no-async-in-computed-properties.md) | disallow asynchronous actions in computed properties |
+| :white_check_mark::wrench: | [html-end-tags](./docs/rules/html-end-tags.md) | enforce end tag style |
+| :white_check_mark: | [no-async-in-computed-properties](./docs/rules/no-async-in-computed-properties.md) | disallow asynchronous actions in computed properties |
 | :white_check_mark: | [no-confusing-v-for-v-if](./docs/rules/no-confusing-v-for-v-if.md) | disallow confusing `v-for` and `v-if` on the same element |
-|  | [no-duplicate-attributes](./docs/rules/no-duplicate-attributes.md) | disallow duplication of attributes |
-|  | [no-side-effects-in-computed-properties](./docs/rules/no-side-effects-in-computed-properties.md) | disallow side effects in computed properties |
+| :white_check_mark: | [no-duplicate-attributes](./docs/rules/no-duplicate-attributes.md) | disallow duplication of attributes |
+| :white_check_mark: | [no-side-effects-in-computed-properties](./docs/rules/no-side-effects-in-computed-properties.md) | disallow side effects in computed properties |
 | :white_check_mark: | [no-textarea-mustache](./docs/rules/no-textarea-mustache.md) | disallow mustaches in `<textarea>` |
-|  | [order-in-components](./docs/rules/order-in-components.md) | enforce order of properties in components |
+| :white_check_mark: | [order-in-components](./docs/rules/order-in-components.md) | enforce order of properties in components |
 | :white_check_mark: | [require-component-is](./docs/rules/require-component-is.md) | require `v-bind:is` of `<component>` elements |
-|  | [require-default-prop](./docs/rules/require-default-prop.md) | require default value for props |
-|  | [require-prop-types](./docs/rules/require-prop-types.md) | require type definitions in props |
+| :white_check_mark: | [require-default-prop](./docs/rules/require-default-prop.md) | require default value for props |
+| :white_check_mark: | [require-prop-types](./docs/rules/require-prop-types.md) | require type definitions in props |
 | :white_check_mark: | [require-v-for-key](./docs/rules/require-v-for-key.md) | require `v-bind:key` with `v-for` directives |
-|  | [this-in-template](./docs/rules/this-in-template.md) | enforce usage of `this` in template |
+| :white_check_mark: | [this-in-template](./docs/rules/this-in-template.md) | enforce usage of `this` in template |
 
 
 ### Stylistic Issues
 
 |    | Rule ID | Description |
 |:---|:--------|:------------|
-| :wrench: | [attribute-hyphenation](./docs/rules/attribute-hyphenation.md) | enforce attribute naming style in template |
+| :white_check_mark::wrench: | [attribute-hyphenation](./docs/rules/attribute-hyphenation.md) | enforce attribute naming style in template |
 | :wrench: | [html-indent](./docs/rules/html-indent.md) | enforce consistent indentation in `<template>` |
 |  | [html-quotes](./docs/rules/html-quotes.md) | enforce quotes style of HTML attributes |
-| :wrench: | [html-self-closing](./docs/rules/html-self-closing.md) | enforce self-closing style |
-|  | [max-attributes-per-line](./docs/rules/max-attributes-per-line.md) | enforce the maximum number of attributes per line |
-| :wrench: | [mustache-interpolation-spacing](./docs/rules/mustache-interpolation-spacing.md) | enforce unified spacing in mustache interpolations |
-| :wrench: | [name-property-casing](./docs/rules/name-property-casing.md) | enforce specific casing for the name property in Vue components |
-| :wrench: | [no-multi-spaces](./docs/rules/no-multi-spaces.md) | disallow multiple spaces |
-| :wrench: | [v-bind-style](./docs/rules/v-bind-style.md) | enforce `v-bind` directive style |
-| :wrench: | [v-on-style](./docs/rules/v-on-style.md) | enforce `v-on` directive style |
+| :white_check_mark::wrench: | [html-self-closing](./docs/rules/html-self-closing.md) | enforce self-closing style |
+| :white_check_mark: | [max-attributes-per-line](./docs/rules/max-attributes-per-line.md) | enforce the maximum number of attributes per line |
+| :white_check_mark::wrench: | [mustache-interpolation-spacing](./docs/rules/mustache-interpolation-spacing.md) | enforce unified spacing in mustache interpolations |
+| :white_check_mark::wrench: | [name-property-casing](./docs/rules/name-property-casing.md) | enforce specific casing for the name property in Vue components |
+| :white_check_mark::wrench: | [no-multi-spaces](./docs/rules/no-multi-spaces.md) | disallow multiple spaces |
+| :white_check_mark::wrench: | [v-bind-style](./docs/rules/v-bind-style.md) | enforce `v-bind` directive style |
+| :white_check_mark::wrench: | [v-on-style](./docs/rules/v-on-style.md) | enforce `v-on` directive style |
 
 
 ### Variables

docs/rules/attribute-hyphenation.md

@@ -1,5 +1,6 @@
 # enforce attribute naming style in template (attribute-hyphenation)
 
+- :white_check_mark: The `"extends": "plugin:vue/recommended"` property in a configuration file enables this rule.
 - :wrench: The `--fix` option on the [command line](http://eslint.org/docs/user-guide/command-line-interface#fix) can automatically fix some of the problems reported by this rule.
 
 ## :wrench: Options

docs/rules/html-end-tags.md

@@ -1,5 +1,6 @@
 # enforce end tag style (html-end-tags)
 
+- :white_check_mark: The `"extends": "plugin:vue/recommended"` property in a configuration file enables this rule.
 - :wrench: The `--fix` option on the [command line](http://eslint.org/docs/user-guide/command-line-interface#fix) can automatically fix some of the problems reported by this rule.
 
 This rule enforce the way of end tags.

docs/rules/html-self-closing.md

@@ -1,5 +1,6 @@
 # enforce self-closing style (html-self-closing)
 
+- :white_check_mark: The `"extends": "plugin:vue/recommended"` property in a configuration file enables this rule.
 - :wrench: The `--fix` option on the [command line](http://eslint.org/docs/user-guide/command-line-interface#fix) can automatically fix some of the problems reported by this rule.
 
 In Vue.js template, we can use either two styles for elements which don't have their content.

docs/rules/max-attributes-per-line.md

@@ -1,5 +1,7 @@
 # enforce the maximum number of attributes per line (max-attributes-per-line)
 
+- :white_check_mark: The `"extends": "plugin:vue/recommended"` property in a configuration file enables this rule.
+
 Limits the maximum number of attributes/properties per line to improve readability.
 
 

docs/rules/mustache-interpolation-spacing.md

@@ -1,5 +1,6 @@
 # enforce unified spacing in mustache interpolations (mustache-interpolation-spacing)
 
+- :white_check_mark: The `"extends": "plugin:vue/recommended"` property in a configuration file enables this rule.
 - :wrench: The `--fix` option on the [command line](http://eslint.org/docs/user-guide/command-line-interface#fix) can automatically fix some of the problems reported by this rule.
 
 ## :book: Rule Details

docs/rules/name-property-casing.md

@@ -1,5 +1,6 @@
 # enforce specific casing for the name property in Vue components (name-property-casing)
 
+- :white_check_mark: The `"extends": "plugin:vue/recommended"` property in a configuration file enables this rule.
 - :wrench: The `--fix` option on the [command line](http://eslint.org/docs/user-guide/command-line-interface#fix) can automatically fix some of the problems reported by this rule.
 
 Define a style for the `name` property casing for consistency purposes.

docs/rules/no-async-in-computed-properties.md

@@ -1,5 +1,7 @@
 # disallow asynchronous actions in computed properties (no-async-in-computed-properties)
 
+- :white_check_mark: The `"extends": "plugin:vue/recommended"` property in a configuration file enables this rule.
+
 Computed properties should be synchronous. Asynchronous actions inside them may not work as expected and can lead to an unexpected behaviour, that's why you should avoid them.
 If you need async computed properties you might want to consider using additional plugin [vue-async-computed]
 

docs/rules/no-dupe-keys.md

@@ -1,5 +1,7 @@
 # disallow duplication of field names (no-dupe-keys)
 
+- :white_check_mark: The `"extends": "plugin:vue/recommended"` property in a configuration file enables this rule.
+
 This rule prevents to use duplicated names.
 
 ## :book: Rule Details

docs/rules/no-duplicate-attributes.md

@@ -1,5 +1,7 @@
 # disallow duplication of attributes (no-duplicate-attributes)
 
+- :white_check_mark: The `"extends": "plugin:vue/recommended"` property in a configuration file enables this rule.
+
 When duplicate arguments exist, only the last one is valid.
 It's possibly mistakes.
 
@@ -33,7 +35,7 @@ This rule reports duplicate attributes.
 ```
 'vue/no-duplicate-attributes': [2, {
   allowCoexistClass: Boolean // default: true
-  allowCoexistStyle: Boolean, // default: true
+  allowCoexistStyle: Boolean, // default: false
 }]
 ```
 

docs/rules/no-multi-spaces.md

@@ -1,5 +1,6 @@
 # disallow multiple spaces (no-multi-spaces)
 
+- :white_check_mark: The `"extends": "plugin:vue/recommended"` property in a configuration file enables this rule.
 - :wrench: The `--fix` option on the [command line](http://eslint.org/docs/user-guide/command-line-interface#fix) can automatically fix some of the problems reported by this rule.
 
 The `--fix` option on the command line can automatically fix some of the problems reported by this rule.

docs/rules/no-reserved-keys.md

@@ -1,5 +1,7 @@
 # disallow overwriting reserved keys (no-reserved-keys)
 
+- :white_check_mark: The `"extends": "plugin:vue/recommended"` property in a configuration file enables this rule.
+
 This rule prevents to use reserved names from to avoid conflicts and unexpected behavior.
 
 ## Rule Details

docs/rules/no-shared-component-data.md

@@ -1,5 +1,7 @@
 # enforce component's data property to be a function (no-shared-component-data)
 
+- :white_check_mark: The `"extends": "plugin:vue/recommended"` property in a configuration file enables this rule.
+
 When using the data property on a component (i.e. anywhere except on `new Vue`), the value must be a function that returns an object.
 
 ## :book: Rule Details

docs/rules/no-side-effects-in-computed-properties.md

@@ -1,5 +1,7 @@
 # disallow side effects in computed properties (no-side-effects-in-computed-properties)
 
+- :white_check_mark: The `"extends": "plugin:vue/recommended"` property in a configuration file enables this rule.
+
 It is considered a very bad practice to introduce side effects inside computed properties. It makes the code not predictable and hard to understand.
 
 

docs/rules/no-template-key.md

@@ -1,5 +1,7 @@
 # disallow `key` attribute on `<template>` (no-template-key)
 
+- :white_check_mark: The `"extends": "plugin:vue/recommended"` property in a configuration file enables this rule.
+
 Vue.js disallows `key` attribute on `<template>` elements.
 
 ## :book: Rule Details

docs/rules/order-in-components.md

@@ -1,5 +1,7 @@
 # enforce order of properties in components (order-in-components)
 
+- :white_check_mark: The `"extends": "plugin:vue/recommended"` property in a configuration file enables this rule.
+
 This rule makes sure you keep declared order of properties in components.
 
 ## :book: Rule Details

docs/rules/require-default-prop.md

@@ -1,5 +1,7 @@
 # require default value for props (require-default-prop)
 
+- :white_check_mark: The `"extends": "plugin:vue/recommended"` property in a configuration file enables this rule.
+
 This rule requires default value to be set for each props that are not marked as `required`.
 
 ## Rule Details

docs/rules/require-prop-types.md

@@ -1,5 +1,7 @@
 # require type definitions in props (require-prop-types)
 
+- :white_check_mark: The `"extends": "plugin:vue/recommended"` property in a configuration file enables this rule.
+
 In committed code, prop definitions should always be as detailed as possible, specifying at least type(s).
 
 ## :book: Rule Details

docs/rules/require-render-return.md

@@ -1,5 +1,7 @@
 # enforce render function to always return value (require-render-return)
 
+- :white_check_mark: The `"extends": "plugin:vue/recommended"` property in a configuration file enables this rule.
+
 This rule aims to enforce render function to always return value
 
 ## :book: Rule Details

docs/rules/require-valid-default-prop.md

@@ -1,5 +1,7 @@
 # enforce props default values to be valid (require-valid-default-prop)
 
+- :white_check_mark: The `"extends": "plugin:vue/recommended"` property in a configuration file enables this rule.
+
 This rule checks whether the default value of each prop is valid for the given type. It should report an error when default value for type `Array` or `Object` is not returned using function.
 
 ## :book: Rule Details

docs/rules/return-in-computed-property.md

@@ -1,5 +1,7 @@
 # enforce that a return statement is present in computed property (return-in-computed-property)
 
+- :white_check_mark: The `"extends": "plugin:vue/recommended"` property in a configuration file enables this rule.
+
 ## :book: Rule Details
 
 This rule enforces that a `return` statement is present in `computed` properties.

docs/rules/this-in-template.md

@@ -1,5 +1,7 @@
 # enforce usage of `this` in template (this-in-template)
 
+- :white_check_mark: The `"extends": "plugin:vue/recommended"` property in a configuration file enables this rule.
+
 ## :book: Rule Details
 
 :-1: Examples of **incorrect** code for this rule:

docs/rules/v-bind-style.md

@@ -1,5 +1,6 @@
 # enforce `v-bind` directive style (v-bind-style)
 
+- :white_check_mark: The `"extends": "plugin:vue/recommended"` property in a configuration file enables this rule.
 - :wrench: The `--fix` option on the [command line](http://eslint.org/docs/user-guide/command-line-interface#fix) can automatically fix some of the problems reported by this rule.
 
 This rule enforces `v-bind` directive style which you should use shorthand or long form.

docs/rules/v-on-style.md

@@ -1,5 +1,6 @@
 # enforce `v-on` directive style (v-on-style)
 
+- :white_check_mark: The `"extends": "plugin:vue/recommended"` property in a configuration file enables this rule.
 - :wrench: The `--fix` option on the [command line](http://eslint.org/docs/user-guide/command-line-interface#fix) can automatically fix some of the problems reported by this rule.
 
 This rule enforces `v-on` directive style which you should use shorthand or long form.

lib/recommended-rules.js

@@ -4,20 +4,20 @@
  * in order to update its content execute "npm run update"
  */
 module.exports = {
-  "vue/attribute-hyphenation": "off",
-  "vue/html-end-tags": "off",
+  "vue/attribute-hyphenation": "error",
+  "vue/html-end-tags": "error",
   "vue/html-indent": "off",
-  "vue/html-no-self-closing": "off",
+  "vue/html-no-self-closing": "error",
   "vue/html-quotes": "off",
-  "vue/html-self-closing": "off",
+  "vue/html-self-closing": "error",
   "vue/jsx-uses-vars": "error",
-  "vue/max-attributes-per-line": "off",
-  "vue/mustache-interpolation-spacing": "off",
-  "vue/name-property-casing": "off",
-  "vue/no-async-in-computed-properties": "off",
+  "vue/max-attributes-per-line": "error",
+  "vue/mustache-interpolation-spacing": "error",
+  "vue/name-property-casing": "error",
+  "vue/no-async-in-computed-properties": "error",
   "vue/no-confusing-v-for-v-if": "error",
-  "vue/no-dupe-keys": "off",
-  "vue/no-duplicate-attributes": "off",
+  "vue/no-dupe-keys": "error",
+  "vue/no-duplicate-attributes": "error",
   "vue/no-invalid-template-root": "off",
   "vue/no-invalid-v-bind": "off",
   "vue/no-invalid-v-cloak": "off",
@@ -32,26 +32,26 @@ module.exports = {
   "vue/no-invalid-v-pre": "off",
   "vue/no-invalid-v-show": "off",
   "vue/no-invalid-v-text": "off",
-  "vue/no-multi-spaces": "off",
+  "vue/no-multi-spaces": "error",
   "vue/no-parsing-error": "error",
-  "vue/no-reserved-keys": "off",
+  "vue/no-reserved-keys": "error",
   "vue/no-reservered-keys": "off",
-  "vue/no-shared-component-data": "off",
-  "vue/no-side-effects-in-computed-properties": "off",
-  "vue/no-template-key": "off",
+  "vue/no-shared-component-data": "error",
+  "vue/no-side-effects-in-computed-properties": "error",
+  "vue/no-template-key": "error",
   "vue/no-textarea-mustache": "error",
   "vue/no-unused-vars": "off",
-  "vue/order-in-components": "off",
+  "vue/order-in-components": "error",
   "vue/require-component-is": "error",
-  "vue/require-default-prop": "off",
-  "vue/require-prop-types": "off",
-  "vue/require-render-return": "off",
+  "vue/require-default-prop": "error",
+  "vue/require-prop-types": "error",
+  "vue/require-render-return": "error",
   "vue/require-v-for-key": "error",
-  "vue/require-valid-default-prop": "off",
-  "vue/return-in-computed-property": "off",
-  "vue/this-in-template": "off",
-  "vue/v-bind-style": "off",
-  "vue/v-on-style": "off",
+  "vue/require-valid-default-prop": "error",
+  "vue/return-in-computed-property": "error",
+  "vue/this-in-template": "error",
+  "vue/v-bind-style": "error",
+  "vue/v-on-style": "error",
   "vue/valid-template-root": "error",
   "vue/valid-v-bind": "error",
   "vue/valid-v-cloak": "error",

lib/rules/attribute-hyphenation.js

@@ -60,7 +60,7 @@ module.exports = {
     docs: {
       description: 'enforce attribute naming style in template',
       category: 'Stylistic Issues',
-      recommended: false
+      recommended: true
     },
     fixable: 'code',
     schema: [

lib/rules/html-end-tags.js

@@ -61,7 +61,7 @@ module.exports = {
     docs: {
       description: 'enforce end tag style',
       category: 'Best Practices',
-      recommended: false
+      recommended: true
     },
     fixable: 'code',
     schema: []

lib/rules/html-no-self-closing.js

@@ -54,7 +54,7 @@ module.exports = {
     docs: {
       description: 'disallow self-closing elements',
       category: 'Best Practices',
-      recommended: false,
+      recommended: true,
       replacedBy: ['html-self-closing']
     },
     deprecated: true,

lib/rules/html-quotes.js

@@ -57,7 +57,7 @@ module.exports = {
     },
     fixable: false,
     schema: [
-            { enum: ['double', 'single'] }
+      { enum: ['double', 'single'] }
     ]
   }
 }