Skip to content

Commit c697725

Browse files
committed
feat: use webpack.Compilation.PROCESS_ASSETS_STAGE_ADDITIONS to add favicons
1 parent 0c5e4ff commit c697725

File tree

1 file changed

+4
-16
lines changed

1 file changed

+4
-16
lines changed

index.js

+4-16
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,6 @@ const chunkSorter = require('./lib/chunksorter.js');
2525
const getHtmlWebpackPluginHooks = require('./lib/hooks.js').getHtmlWebpackPluginHooks;
2626
const { assert } = require('console');
2727

28-
const fsStatAsync = promisify(fs.stat);
2928
const fsReadFileAsync = promisify(fs.readFile);
3029

3130
class HtmlWebpackPlugin {
@@ -469,24 +468,13 @@ function hookIntoCompiler (compiler, options, plugin) {
469468
*/
470469
function addFileToAssets (filename, compilation) {
471470
filename = path.resolve(compilation.compiler.context, filename);
472-
return Promise.all([
473-
fsStatAsync(filename),
474-
fsReadFileAsync(filename)
475-
])
476-
.then(([size, source]) => {
477-
return {
478-
size,
479-
source
480-
};
481-
})
471+
return fsReadFileAsync(filename)
472+
.then(source => new webpack.sources.RawSource(source, true))
482473
.catch(() => Promise.reject(new Error('HtmlWebpackPlugin: could not load file ' + filename)))
483-
.then(results => {
474+
.then(rawSource => {
484475
const basename = path.basename(filename);
485476
compilation.fileDependencies.add(filename);
486-
compilation.assets[basename] = {
487-
source: () => results.source,
488-
size: () => results.size.size
489-
};
477+
compilation.emitAsset(basename, rawSource);
490478
return basename;
491479
});
492480
}

0 commit comments

Comments
 (0)