refactor(angular.js): improve trim performance

sunnylost · jamesdaily · commit 4a044af2cfa3 · 2014-01-26T22:10:12.000-05:00
According to Flagrant Badassery's blog http://blog.stevenlevithan.com/archives/faster-trim-javascript and this comparison http://jsperf.com/trim-function, this trim method is faster. Closes angular#4406
diff --git a/src/Angular.js b/src/Angular.js
@@ -544,7 +544,7 @@ var trim = (function() {
   // TODO: we should move this into IE/ES5 polyfill
   if (!String.prototype.trim) {
     return function(value) {
-      return isString(value) ? value.replace(/^\s*/, '').replace(/\s*$/, '') : value;
+      return isString(value) ? value.replace(/^\s\s*/, '').replace(/\s\s*$/, '') : value;
     };
   }
   return function(value) {

Original file line number	Diff line number	Diff line change
`@@ -544,7 +544,7 @@ var trim = (function() {`
`544`	`544`	`// TODO: we should move this into IE/ES5 polyfill`
`545`	`545`	`if (!String.prototype.trim) {`
`546`	`546`	`return function(value) {`
`547`		`- return isString(value) ? value.replace(/^\s/, '').replace(/\s$/, '') : value;`
	`547`	`+ return isString(value) ? value.replace(/^\s\s/, '').replace(/\s\s$/, '') : value;`
`548`	`548`	`};`
`549`	`549`	`}`
`550`	`550`	`return function(value) {`