fix(ngMocks): $logProvider should not use internal APIs

Adam de Baugh · jamesdaily · commit 03fbbf3764b8 · 2013-09-25T09:06:02.000-04:00
angular.mocks.$LogProvider $logProvider.debugEnabled(false) is crashing with undefined when run inside karma/jasmine test runner: angular.module('foo', []).config(['$logProvider', function ($logProvider) { $logProvider.debugEnabled(false); }]); Closes angular#3612
diff --git a/src/ngMock/angular-mocks.js b/src/ngMock/angular-mocks.js
@@ -316,7 +316,7 @@ angular.mock.$LogProvider = function() {
   }
 
   this.debugEnabled = function(flag) {
-	  if (isDefined(flag)) {
+	  if (angular.isDefined(flag)) {
 		  debug = flag;
 		  return this;
 	  } else {

Original file line number	Diff line number	Diff line change
`@@ -316,7 +316,7 @@ angular.mock.$LogProvider = function() {`
`316`	`316`	`}`
`317`	`317`
`318`	`318`	`this.debugEnabled = function(flag) {`
`319`		`- if (isDefined(flag)) {`
	`319`	`+ if (angular.isDefined(flag)) {`
`320`	`320`	`debug = flag;`
`321`	`321`	`return this;`
`322`	`322`	`} else {`