Skip to content

Commit 852ac73

Browse files
committed
Fix ordering on some properties
1 parent 6063fc1 commit 852ac73

File tree

2 files changed

+7
-7
lines changed

2 files changed

+7
-7
lines changed

src/js/DualListBox.js

+5-5
Original file line numberDiff line numberDiff line change
@@ -499,14 +499,14 @@ class DualListBox extends React.Component {
499499
const selectedOptions = this.renderOptions(this.filterSelected(options));
500500
const actionsRight = (
501501
<div className="rdl-actions-right">
502-
<Action disabled={disabled} direction="right" isMoveAll onClick={this.onClick} />
503-
<Action disabled={disabled} direction="right" onClick={this.onClick} />
502+
<Action direction="right" disabled={disabled} isMoveAll onClick={this.onClick} />
503+
<Action direction="right" disabled={disabled} onClick={this.onClick} />
504504
</div>
505505
);
506506
const actionsLeft = (
507507
<div className="rdl-actions-left">
508-
<Action disabled={disabled} direction="left" onClick={this.onClick} />
509-
<Action disabled={disabled} direction="left" isMoveAll onClick={this.onClick} />
508+
<Action direction="left" disabled={disabled} onClick={this.onClick} />
509+
<Action direction="left" disabled={disabled} isMoveAll onClick={this.onClick} />
510510
</div>
511511
);
512512

@@ -527,7 +527,7 @@ class DualListBox extends React.Component {
527527
</div>
528528
) : null}
529529
{this.renderListBox('selected', selectedLabel, selectedOptions, selectedRef, actionsLeft)}
530-
<input disabled={disabled} name={name} value={value} type="hidden" />
530+
<input disabled={disabled} name={name} type="hidden" value={value} />
531531
</div>
532532
);
533533
}

test/DualListBox.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -413,8 +413,8 @@ describe('<DualListBox />', () => {
413413
{ label: 'Moon', value: 'luna' },
414414
{ label: 'Phobos', value: 'phobos' },
415415
]}
416-
onChange={() => {}}
417416
selected={['phobos']}
417+
onChange={() => {}}
418418
/>
419419
));
420420

@@ -598,10 +598,10 @@ describe('<DualListBox />', () => {
598598
{ label: 'Moon', value: 'luna' },
599599
{ label: 'Phobos', value: 'phobos' },
600600
]}
601+
selected={['phobos']}
601602
onChange={(selected) => {
602603
actual = selected;
603604
}}
604-
selected={['phobos']}
605605
/>
606606
));
607607

0 commit comments

Comments
 (0)