Skip to content

Commit eee835f

Browse files
committed
issue http-party#953: stop using writeHead
object.keys in web-incoming.js results in a non-deterministic ordering of keys, which means that in web-outgoing writeHead might be called before setHeader, which throws an error
1 parent c979ba9 commit eee835f

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

lib/http-proxy/passes/web-outgoing.js

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -129,9 +129,10 @@ module.exports = { // <--
129129
writeStatusCode: function writeStatusCode(req, res, proxyRes) {
130130
// From Node.js docs: response.writeHead(statusCode[, statusMessage][, headers])
131131
if(proxyRes.statusMessage) {
132-
res.writeHead(proxyRes.statusCode, proxyRes.statusMessage);
132+
res.statusCode = proxyRes.statusCode;
133+
res.statusMessage = proxyRes.statusMessage;
133134
} else {
134-
res.writeHead(proxyRes.statusCode);
135+
res.statusCode = proxyRes.statusCode;
135136
}
136137
}
137138

0 commit comments

Comments
 (0)