Skip to content

Commit 73843ec

Browse files
authored
Deprecate --visualize in favor of concrete playback (rust-lang#3281)
We believe the `--visualize` is much harder to use than concrete playback. In the rare cases where a trace might be relevant, users can still use CBMC trace. For most users, this will simplify installation since Kani will no longer depend on Python3. Note: As opposed to `--function` which was purely an internal feature, I believe we have mentioned `--visualize` to users before, so I think it's important to have a deprecation period. Related rust-lang#2832
1 parent 0d8675d commit 73843ec

File tree

2 files changed

+10
-5
lines changed

2 files changed

+10
-5
lines changed

kani-driver/src/args/mod.rs

Lines changed: 9 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -532,12 +532,16 @@ impl ValidateArgs for VerificationArgs {
532532
);
533533
}
534534

535-
if self.visualize && !self.common_args.enable_unstable {
536-
return Err(Error::raw(
537-
ErrorKind::MissingRequiredArgument,
538-
"Missing argument: --visualize now requires --enable-unstable
535+
if self.visualize {
536+
if !self.common_args.enable_unstable {
537+
return Err(Error::raw(
538+
ErrorKind::MissingRequiredArgument,
539+
"Missing argument: --visualize now requires --enable-unstable
539540
due to open issues involving incorrect results.",
540-
));
541+
));
542+
} else {
543+
print_deprecated(&self.common_args, "--visualize", "--concrete-playback");
544+
}
541545
}
542546

543547
if self.mir_linker {
Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1 +1,2 @@
1+
warning: The `--visualize` option is deprecated. This option will be removed soon. Consider using `--concrete-playback` instead
12
report-main/html/index.html

0 commit comments

Comments
 (0)