Skip to content

Rename RoutesConfig #222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kujtimiihoxha opened this issue Mar 26, 2016 · 4 comments
Closed

Rename RoutesConfig #222

kujtimiihoxha opened this issue Mar 26, 2016 · 4 comments
Assignees
Milestone

Comments

@kujtimiihoxha
Copy link
Contributor

I think we should rename RoutresConfig.js to routes.config.js so we maintain the naming convention for all config files.

@jadjoubran
Copy link
Owner

Yes indeed, but first let's double check with @jadsalhani (author if this fike) if there is a reason behind this naming

@jadjoubran jadjoubran added this to the Version 3.2 milestone Mar 26, 2016
@jadsalhani
Copy link
Collaborator

👍 Must have missed it when adding the fix

@jadsalhani jadsalhani self-assigned this Mar 26, 2016
@kujtimiihoxha
Copy link
Contributor Author

@jadjoubran Don't forget to change index.routes.js, also I would suggest to completely remove index.routes.js and add the routes configuration to the index.config.js as all other config files.

@jadjoubran
Copy link
Owner

Woups you're right
And yes I totally I agree I'll fix it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants