Skip to content

Commit 7753a1a

Browse files
Fix GitHub Actions:
golangci-lint was failing. Upgraded golangci-lint to v2 and reordered it to first as a modified `go.mod` file was causing errors. ref: golangci/golangci-lint-action#23 (comment) Signed-off-by: Jacob Weinstock <[email protected]>
1 parent 8550156 commit 7753a1a

File tree

1 file changed

+8
-7
lines changed

1 file changed

+8
-7
lines changed

.github/workflows/ci.yaml

Lines changed: 8 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -14,16 +14,16 @@ jobs:
1414
- name: Install Go
1515
uses: actions/setup-go@v2
1616
with:
17-
go-version: '1.14.6'
17+
go-version: '1.15.5'
18+
- name: golangci-lint
19+
uses: golangci/golangci-lint-action@v2
20+
with:
21+
version: v1.32
22+
args: -v -D errcheck
1823
- name: go fmt
1924
run: go get golang.org/x/tools/cmd/goimports && goimports -d . | (! grep .)
2025
- name: go vet
2126
run: go vet ./...
22-
- name: golangci-lint
23-
uses: golangci/golangci-lint-action@v1
24-
with:
25-
version: v1.30
26-
args: -v -D errcheck
2727
- name: go test
2828
run: go test -v ./...
2929
- name: go test coverage
@@ -58,6 +58,7 @@ jobs:
5858
uses: docker/setup-buildx-action@v1
5959
- name: Login to quay.io
6060
uses: docker/login-action@v1
61+
if: ${{ startsWith(github.ref, 'refs/heads/master') }}
6162
with:
6263
registry: quay.io
6364
username: ${{ secrets.QUAY_USERNAME }}
@@ -69,4 +70,4 @@ jobs:
6970
file: ./Dockerfile
7071
cache-from: type=registry,ref=quay.io/tinkerbell/pbnj:latest
7172
push: ${{ startsWith(github.ref, 'refs/heads/master') }}
72-
tags: ${{ steps.docker-image-tag.outputs.tags }}
73+
tags: ${{ steps.docker-image-tag.outputs.tags }}

0 commit comments

Comments
 (0)