Skip to content

Commit da71a82

Browse files
jrbourbeauj-bennet
authored andcommitted
Use PYARROW_STRINGS_AVAILABLE more
1 parent 1cb49d9 commit da71a82

File tree

3 files changed

+6
-21
lines changed

3 files changed

+6
-21
lines changed

conftest.py

+2-8
Original file line numberDiff line numberDiff line change
@@ -28,15 +28,9 @@
2828
import pandas # noqa: F401
2929

3030
# Temporary changes to look for pyarrow string failures
31-
import dask
32-
from dask.dataframe._compat import PANDAS_GT_130
31+
from dask.dataframe._pyarrow_utils import PYARROW_STRINGS_AVAILABLE
3332

34-
try:
35-
import pyarrow
36-
except ImportError:
37-
pyarrow = False
38-
39-
if PANDAS_GT_130 and pyarrow:
33+
if PYARROW_STRINGS_AVAILABLE:
4034
dask.config.set({"dataframe.object_as_pyarrow_string": True})
4135
except ImportError:
4236
collect_ignore_glob.append("dask/dataframe/*")

dask/dataframe/io/tests/test_csv.py

+2-6
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@
1818
from dask.bytes.utils import compress
1919
from dask.core import flatten
2020
from dask.dataframe._compat import tm
21+
from dask.dataframe._pyarrow_utils import PYARROW_STRINGS_AVAILABLE
2122
from dask.dataframe.io.csv import (
2223
_infer_block_size,
2324
auto_blocksize,
@@ -360,13 +361,8 @@ def test_read_csv(dd_read, pd_read, text, sep):
360361
assert_eq(result, pd_read(fn, sep=sep))
361362

362363

364+
@pytest.mark.skipif(not PYARROW_STRINGS_AVAILABLE, reason="Requires pyarrow strings")
363365
def test_read_csv_object_as_pyarrow_string_config():
364-
pytest.importorskip(
365-
"pandas",
366-
minversion="1.3.0",
367-
reason="Requires support for pyarrow strings",
368-
)
369-
pytest.importorskip("pyarrow", reason="Requires pyarrow")
370366
with filetext(csv_text) as fn:
371367
df = pd.read_csv(fn)
372368
with dask.config.set({"dataframe.object_as_pyarrow_string": True}):

dask/dataframe/io/tests/test_io.py

+2-7
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@
1010
from dask import config
1111
from dask.blockwise import Blockwise
1212
from dask.dataframe._compat import tm
13+
from dask.dataframe._pyarrow_utils import PYARROW_STRINGS_AVAILABLE
1314
from dask.dataframe.io.io import _meta_from_array
1415
from dask.dataframe.optimize import optimize
1516
from dask.dataframe.utils import assert_eq
@@ -275,14 +276,8 @@ def test_from_pandas_npartitions_duplicates(index):
275276
assert ddf.divisions == ("A", "B", "C", "C")
276277

277278

279+
@pytest.mark.skipif(not PYARROW_STRINGS_AVAILABLE, reason="Requires pyarrow strings")
278280
def test_from_pandas_object_as_pyarrow_string_config():
279-
pytest.importorskip(
280-
"pandas",
281-
minversion="1.3.0",
282-
reason="Requires support for pyarrow strings",
283-
)
284-
pytest.importorskip("pyarrow", reason="Requires pyarrow")
285-
286281
# `dataframe.object_as_pyarrow_string` defaults to `False`
287282
s = pd.Series(["foo", "bar", "ricky", "bobby"], index=["a", "b", "c", "d"])
288283
df = pd.DataFrame(

0 commit comments

Comments
 (0)