Skip to content

Commit 4e5111d

Browse files
authored
fix: addresses several test-exclude edge-cases. addresses perf issue with yargs (#444)
2 parents cc96078 + 21a9a70 commit 4e5111d

File tree

2 files changed

+6
-6
lines changed

2 files changed

+6
-6
lines changed

package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -95,8 +95,8 @@
9595
"rimraf": "^2.5.4",
9696
"signal-exit": "^3.0.1",
9797
"spawn-wrap": "^1.2.4",
98-
"test-exclude": "^3.0.0",
99-
"yargs": "^6.0.0",
98+
"test-exclude": "^3.2.2",
99+
"yargs": "^6.4.0",
100100
"yargs-parser": "^4.0.2"
101101
},
102102
"devDependencies": {

test/src/nyc-test.js

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,7 @@ describe('nyc', function () {
6666
describe('config', function () {
6767
it("loads 'exclude' patterns from package.json#nyc", function () {
6868
var nyc = new NYC(configUtil.loadConfig([], path.resolve(__dirname, '../fixtures')))
69-
nyc.exclude.exclude.length.should.eql(5)
69+
nyc.exclude.exclude.length.should.eql(8)
7070
})
7171

7272
it("loads 'extension' patterns from package.json#nyc", function () {
@@ -91,14 +91,14 @@ describe('nyc', function () {
9191

9292
it("ignores 'exclude' option if it's falsy", function () {
9393
var nyc1 = new NYC(configUtil.loadConfig([], path.resolve(__dirname, '../fixtures/conf-empty')))
94-
nyc1.exclude.exclude.length.should.eql(7)
94+
nyc1.exclude.exclude.length.should.eql(10)
9595
})
9696

9797
it("allows for empty 'exclude'", function () {
9898
var nyc2 = new NYC({exclude: []})
9999

100-
// an empty exclude still has !**/node_modules/** added.
101-
nyc2.exclude.exclude.length.should.eql(1)
100+
// an empty exclude still has **/node_modules/**, node_modules/** and added.
101+
nyc2.exclude.exclude.length.should.eql(2)
102102
})
103103
})
104104

0 commit comments

Comments
 (0)