Skip to content

Commit 7d858a8

Browse files
nirrozenbaumirar2
authored andcommitted
use namespacedname instead of name/namespace as separate args (kubernetes-sigs#873)
Signed-off-by: Nir Rozenbaum <[email protected]>
1 parent bd98d73 commit 7d858a8

File tree

2 files changed

+5
-4
lines changed

2 files changed

+5
-4
lines changed

test/e2e/epp/e2e_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -100,7 +100,7 @@ func newInferenceModel(ns string) *v1alpha2.InferenceModel {
100100
Weight: ptr.To(int32(100)),
101101
},
102102
}
103-
return testutils.MakeModelWrapper("inferencemodel-sample", ns).
103+
return testutils.MakeModelWrapper(types.NamespacedName{Name: "inferencemodel-sample", Namespace: ns}).
104104
SetCriticality(v1alpha2.Critical).
105105
SetModelName(modelName).
106106
SetPoolRef(modelServerName).

test/utils/wrappers.go

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@ package utils
1818

1919
import (
2020
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
21+
"k8s.io/apimachinery/pkg/types"
2122
"sigs.k8s.io/gateway-api-inference-extension/api/v1alpha2"
2223
)
2324

@@ -27,12 +28,12 @@ type InferenceModelWrapper struct {
2728
}
2829

2930
// MakeModelWrapper creates a wrapper for an MakeModelWrapper.
30-
func MakeModelWrapper(name, ns string) *InferenceModelWrapper {
31+
func MakeModelWrapper(namespacedName types.NamespacedName) *InferenceModelWrapper {
3132
return &InferenceModelWrapper{
3233
v1alpha2.InferenceModel{
3334
ObjectMeta: metav1.ObjectMeta{
34-
Name: name,
35-
Namespace: ns,
35+
Name: namespacedName.Name,
36+
Namespace: namespacedName.Namespace,
3637
},
3738
Spec: v1alpha2.InferenceModelSpec{
3839
ModelName: "",

0 commit comments

Comments
 (0)