Skip to content

Commit 38c4da3

Browse files
authored
chore(ci): use node v18 for github actions (#28103)
Issue number: N/A --------- <!-- Please do not submit updates to dependencies unless it fixes an issue. --> <!-- Please try to limit your pull request to one type (bugfix, feature, etc). Submit multiple pull requests if needed. --> ## What is the current behavior? <!-- Please describe the current behavior that you are modifying. --> `action/setup-node@v3` shipped a "breaking" change that requires node v18. This breaks our dev build release process. https://github.com/ionic-team/ionic-framework/actions/runs/6044495970/job/16403194005 ## What is the new behavior? <!-- Please describe the behavior or changes that are being added by this PR. --> - Updates the publish action to use node v18 ## Does this introduce a breaking change? - [ ] Yes - [x] No <!-- If this introduces a breaking change, please describe the impact and migration path for existing applications below. --> ## Other information <!-- Any other information that is important to this PR such as screenshots of how the component looks before and after the change. --> Here is a successful run with these changes: https://github.com/ionic-team/ionic-framework/actions/runs/6044521110
1 parent f74ad63 commit 38c4da3

File tree

17 files changed

+17
-17
lines changed

17 files changed

+17
-17
lines changed

.github/workflows/actions/build-angular-server/action.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ runs:
55
steps:
66
- uses: actions/setup-node@v3
77
with:
8-
node-version: 16.x
8+
node-version: 18.x
99

1010
- name: Install Angular Server Dependencies
1111
run: npm ci

.github/workflows/actions/build-angular/action.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ runs:
55
steps:
66
- uses: actions/setup-node@v3
77
with:
8-
node-version: 16.x
8+
node-version: 18.x
99
- uses: ./.github/workflows/actions/download-archive
1010
with:
1111
name: ionic-core

.github/workflows/actions/build-core-stencil-prerelease/action.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ runs:
1111
- uses: actions/checkout@v3
1212
- uses: actions/setup-node@v3
1313
with:
14-
node-version: 16.x
14+
node-version: 18.x
1515

1616
- name: Install Dependencies
1717
run: npm ci

.github/workflows/actions/build-core/action.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ runs:
66
- uses: actions/checkout@v3
77
- uses: actions/setup-node@v3
88
with:
9-
node-version: 16.x
9+
node-version: 18.x
1010
- name: Install Dependencies
1111
run: npm install
1212
working-directory: ./core

.github/workflows/actions/build-react-router/action.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ runs:
55
steps:
66
- uses: actions/setup-node@v3
77
with:
8-
node-version: 16.x
8+
node-version: 18.x
99
- uses: ./.github/workflows/actions/download-archive
1010
with:
1111
name: ionic-core

.github/workflows/actions/build-react/action.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ runs:
55
steps:
66
- uses: actions/setup-node@v3
77
with:
8-
node-version: 16.x
8+
node-version: 18.x
99
- uses: ./.github/workflows/actions/download-archive
1010
with:
1111
name: ionic-core

.github/workflows/actions/build-vue-router/action.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ runs:
55
steps:
66
- uses: actions/setup-node@v3
77
with:
8-
node-version: 16.x
8+
node-version: 18.x
99
- uses: ./.github/workflows/actions/download-archive
1010
with:
1111
name: ionic-core

.github/workflows/actions/build-vue/action.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ runs:
55
steps:
66
- uses: actions/setup-node@v3
77
with:
8-
node-version: 16.x
8+
node-version: 18.x
99
- uses: ./.github/workflows/actions/download-archive
1010
with:
1111
name: ionic-core

.github/workflows/actions/publish-npm/action.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ runs:
2121
steps:
2222
- uses: actions/setup-node@v3
2323
with:
24-
node-version: 16.x
24+
node-version: 18.x
2525
# Provenance requires npm 9.5.0+
2626
- name: Install latest npm
2727
run: npm install -g npm@latest

.github/workflows/actions/test-core-clean-build/action.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ runs:
55
steps:
66
- uses: actions/setup-node@v3
77
with:
8-
node-version: 16.x
8+
node-version: 18.x
99

1010
- uses: ./.github/workflows/actions/download-archive
1111
with:

.github/workflows/actions/test-core-lint/action.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ runs:
55
steps:
66
- uses: actions/setup-node@v3
77
with:
8-
node-version: 16.x
8+
node-version: 18.x
99
- name: Install Dependencies
1010
run: npm ci
1111
working-directory: ./core

.github/workflows/actions/test-core-screenshot/action.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ runs:
1313
steps:
1414
- uses: actions/setup-node@v3
1515
with:
16-
node-version: 16.x
16+
node-version: 18.x
1717
- uses: ./.github/workflows/actions/download-archive
1818
with:
1919
name: ionic-core

.github/workflows/actions/test-core-spec/action.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ runs:
88
steps:
99
- uses: actions/setup-node@v3
1010
with:
11-
node-version: 16.x
11+
node-version: 18.x
1212
- name: Install Dependencies
1313
run: npm ci
1414
working-directory: ./core

.github/workflows/actions/test-react-e2e/action.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ runs:
88
steps:
99
- uses: actions/setup-node@v3
1010
with:
11-
node-version: 16.x
11+
node-version: 18.x
1212
- uses: ./.github/workflows/actions/download-archive
1313
with:
1414
name: ionic-core

.github/workflows/actions/test-react-router-e2e/action.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ runs:
88
steps:
99
- uses: actions/setup-node@v3
1010
with:
11-
node-version: 16.x
11+
node-version: 18.x
1212
- uses: ./.github/workflows/actions/download-archive
1313
with:
1414
name: ionic-core

.github/workflows/actions/test-vue-e2e/action.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ runs:
88
steps:
99
- uses: actions/setup-node@v3
1010
with:
11-
node-version: 16.x
11+
node-version: 18.x
1212
- uses: ./.github/workflows/actions/download-archive
1313
with:
1414
name: ionic-core

.github/workflows/actions/update-reference-screenshots/action.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ runs:
99
steps:
1010
- uses: actions/setup-node@v3
1111
with:
12-
node-version: 16.x
12+
node-version: 18.x
1313
- uses: actions/download-artifact@v3
1414
with:
1515
path: ./artifacts

0 commit comments

Comments
 (0)