Skip to content
This repository was archived by the owner on May 1, 2020. It is now read-only.

Changes in linked modules not triggering changes #380

Closed
alan-agius4 opened this issue Nov 12, 2016 · 1 comment
Closed

Changes in linked modules not triggering changes #380

alan-agius4 opened this issue Nov 12, 2016 · 1 comment

Comments

@alan-agius4
Copy link
Contributor

alan-agius4 commented Nov 12, 2016

Short description of the problem:

When you link npm module you still need to listen for changes on them. The file extension in would mainly be js which at the time being is not handled.

Used to work in 0.0.41

What behavior are you expecting?

Bundles again

Steps to reproduce:

  1. npm link a library
  2. Do a change in the library and build
  3. Change is detected but nothing else happens
module.exports = {
  watchers: [
    {
      paths: [
        'node_modules/mylib/dist/**/*.(js|scss)',
        '{{SRC}}/**/*.(ts|html|scss)'
      ],
      options: { ignored: ['{{SRC}}/**/*.spec.ts', '**/*.DS_Store'] },
      callback: watch.buildUpdate
    }
  ]
};

Note: I had to change the index.js of ionic-app-scripts to export buildUpdate from watch rather than build.

Which @ionic/app-scripts version are you using? 0.0.43

@alan-agius4 alan-agius4 changed the title Changes on linked modules not triggering changes Changes in linked modules not triggering changes Nov 12, 2016
@danbucholtz
Copy link
Contributor

We merged the PR, so closing this.

Thanks @alan-agius4.

Thanks,
Dan

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants