AOT issue after upgrade to 2.0.2 #1112

kodeine · 2017-07-14T00:13:11Z

Short description of the problem:

just upgraded ionic-app-scripts and ionic-angular, added vendor.js in index as well but now getting error on AOT which wasnt there on < 2.0.2 of app-scripts. non aot builds with ionic serve is fine.

Steps to reproduce:

ionic cordova build android --prod --release

Which @ionic/app-scripts version are you using?
global packages:

@ionic/cli-utils : 1.5.0
Cordova CLI      : 7.0.1 
Ionic CLI        : 3.5.0

local packages:

@ionic/app-scripts              : 2.0.2
@ionic/cli-plugin-cordova       : 1.4.1
@ionic/cli-plugin-ionic-angular : 1.3.2
Cordova Platforms               : android 6.2.3
Ionic Framework                 : ionic-angular 3.5.2

System:

Node       : v6.6.0
OS         : Linux 4.2
Xcode      : not installed
ios-deploy : not installed
ios-sim    : not installed
npm        : 5.0.4

The text was updated successfully, but these errors were encountered:

danbucholtz · 2017-07-14T02:41:42Z

@kodeine,

How can I recreate this? What angular version do you have?

Thanks,
Dan

kodeine · 2017-07-14T03:38:03Z

@danbucholtz its 4.1.3

 "dependencies": {
        "@angular/animations": "4.1.3",
        "@angular/common": "4.1.3",
        "@angular/compiler": "4.1.3",
        "@angular/compiler-cli": "4.1.3",
        "@angular/core": "4.1.3",
        "@angular/forms": "4.1.3",
        "@angular/http": "4.1.3",

danbucholtz · 2017-07-14T04:19:01Z

Can you try with 4.0.1 of app-scripts? I am confused, nothing here has changed in a good long while. Can you try with 1.3.12?
Thanks,
Dan

kodeine · 2017-07-14T04:25:25Z

4.0.1 of app-scripts? or you mean angular?
app-scripts 1.3.12 worked fine earlier, going to try again to be 100%

kodeine · 2017-07-14T05:57:26Z

@danbucholtz
okay its confirmed, 2.0.2 breaks aot.

ionic-angular 3.5.2 works fine with app-scripts 1.3.12

marcorosi · 2017-07-14T08:13:50Z

hi, if it can be useful i just upgraded but no issue for me

global packages:

@ionic/cli-utils : 1.5.0
Cordova CLI      : 7.0.1 
Ionic CLI        : 3.5.0

local packages:

@ionic/app-scripts              : 2.0.2
@ionic/cli-plugin-cordova       : 1.4.1
@ionic/cli-plugin-ionic-angular : 1.3.2
Cordova Platforms               : android 6.2.3 ios 4.4.0
Ionic Framework                 : ionic-angular 3.5.2

System:

Node       : v6.10.0
OS         : Linux 4.4
Xcode      : not installed
ios-deploy : not installed
ios-sim    : not installed
npm        : 3.10.10

danbucholtz · 2017-07-14T17:31:54Z

@kodeine,

I think this is an npm issue. They have had a ton of issues with 5.0.x and 5.2.x. Can you try installing npm install -g [email protected]`? That seems to be by far the most stable. I am pretty sure this is a lock file issue.

Thanks,
Dan

kodeine · 2017-07-16T16:18:49Z

@danbucholtz
i've installed npm 5.1.0 and now i am getting this error on ionic serve.

UPDATE:
Ionic serve works with npm 5.1.0

global packages:

    @ionic/cli-utils : 1.5.0
    Cordova CLI      : 7.0.1 
    Ionic CLI        : 3.5.0

local packages:

    @ionic/app-scripts              : 2.0.2
    @ionic/cli-plugin-cordova       : 1.4.1
    @ionic/cli-plugin-ionic-angular : 1.3.2
    Cordova Platforms               : android 6.2.3
    Ionic Framework                 : ionic-angular 3.5.3

System:

    Node       : v6.6.0
    OS         : Linux 4.2
    Xcode      : not installed
    ios-deploy : not installed
    ios-sim    : not installed
    npm        : 5.1.0

kodeine · 2017-07-18T05:00:21Z

@danbucholtz so it works fine on ionic serve but after build release i see the same error

it works fine with app-scripts 1.3.12.

www folder locally has 0.js etc but when it was deployed it doesnt have those files as in the image.. is this how its suppose to be?

vkniazeu · 2017-07-18T17:24:52Z

@kodeine , your webpackJsonp is not defined is due to the missing vendor.js in your index.html.
See https://github.com/ionic-team/ionic-app-scripts/blob/master/CHANGELOG.md#200-2017-07-07

kodeine · 2017-07-18T17:47:10Z

@vkniazeu
thats how my index.html looks.

<body>

<!-- Ionic's root component and where the app will load -->
<ion-app></ion-app>

<!-- The polyfills js is generated during the build process -->
<script src="build/polyfills.js"></script>

<!-- all code from node_modules directory is here -->
<script src="build/vendor.js"></script>

<!-- The bundle js is generated during the build process -->
<script src="build/main.js"></script>

</body>
</html>

vkniazeu · 2017-07-18T17:51:34Z

@kodeine hmm... i'd get that error forgetting to add vendor.js.
I'm, however, on npm 5.3.0.
Try upgrading: npm i -g npm - that helped me before with older ionic-app-scripts issues.

kodeine · 2017-07-18T17:59:00Z

@vkniazeu just updated to 5.3.0 and same damn issue. i got no idea whats causing this even though everything works fine with app-scripts 1.3.12

vkniazeu · 2017-07-18T18:11:12Z

@kodeine, are you using typescript 2.4.1 ? Perhaps, downgrading to 2.3.4 can help?
#1114, #1120 are related to 2.0.2 upgrade, but not sure if they affect this problem.
I've gone down to 2.0.0 for now. Can't give this much more time ATM.

kodeine · 2017-07-18T19:56:52Z

@vkniazeu i've tried with TS 2.3.4 also with app-scripts 2.0.0 same error.
but now i've downgraded app scripts to 1.3.12 and everything works as it should.

danbucholtz · 2017-07-19T04:05:49Z

This seems like a lock file issue to me. How can I recreate? If this was affecting a lot of apps, believe me, we would have heard about it 😸 .

Thanks,
Dan

kodeine · 2017-07-19T04:07:45Z

Give me your email ill allow access to project so you can check it out.

danbucholtz · 2017-07-19T04:08:33Z

Can you recreate in a simple project and upload to github?

Thanks,
Dan

kodeine · 2017-07-19T04:11:46Z

Its already on github but id prefer to keep project private and give u access. It would be easier to debug this way all u wud do is compile

danbucholtz · 2017-07-19T04:14:16Z

Okay, cool, you should be able to add my username danbucholtz.

Thanks,
Dan

kodeine · 2017-07-19T04:15:48Z

Okay give me 1 hr ill go home and add it

kodeine · 2017-07-19T06:04:27Z

@danbucholtz i've given you permissions on the project. Thanks for everything!

trebor678 · 2017-07-20T09:19:19Z

Any news on this? I'm having the same problem

danbucholtz · 2017-07-21T17:16:12Z

I haven't had a chance to look yet. @trebor678, are you doing anything interesting with webpack or anything like that?

Thanks,
Dan

kodeine · 2017-07-25T15:24:26Z

@danbucholtz were you able to take a look at the repo i authorized you at?

danbucholtz · 2017-07-26T06:59:28Z

Sorry, I haven't had a chance yet. It is surprising because nothing with AOT changed in quite a while.

Thanks,
Dan

kodeine · 2017-07-28T17:38:48Z

@danbucholtz i just updated to latest app-scripts and same issue. i'm already pulling off my hair at this point.

kodeine · 2017-07-29T20:17:48Z

@danbucholtz
so i ran npm run build --prod and didnt do the minification etc to debug further. this is what i get after enabling the sourcemaps. ionic serve works just fine.

I re-checked the providers, there doesnt seem to be any problem. I'm super confused.

kodeine · 2017-07-31T06:26:55Z

Looks like typescript issue.
angular/angular-cli#5769

microsoft/TypeScript#14734

microsoft/TypeScript#10837

kodeine · 2017-08-01T20:05:34Z

Problem is fixed! =)

It was a circular dependency issue. After installing https://github.com/aackerman/circular-dependency-plugin i was able to figure out what providers were messing up with circular dependencies.

darmie · 2018-01-09T09:05:48Z

@kodeine I am also having this problem, can you explain how you solved it using Circular Dependency Plugin?

kodeine closed this as completed Aug 1, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

AOT issue after upgrade to 2.0.2 #1112

AOT issue after upgrade to 2.0.2 #1112

kodeine commented Jul 14, 2017

danbucholtz commented Jul 14, 2017

kodeine commented Jul 14, 2017

danbucholtz commented Jul 14, 2017

kodeine commented Jul 14, 2017

kodeine commented Jul 14, 2017

marcorosi commented Jul 14, 2017

danbucholtz commented Jul 14, 2017

kodeine commented Jul 16, 2017 •

edited

Loading

kodeine commented Jul 18, 2017 •

edited

Loading

vkniazeu commented Jul 18, 2017

kodeine commented Jul 18, 2017

vkniazeu commented Jul 18, 2017

kodeine commented Jul 18, 2017

vkniazeu commented Jul 18, 2017

kodeine commented Jul 18, 2017

danbucholtz commented Jul 19, 2017

kodeine commented Jul 19, 2017

danbucholtz commented Jul 19, 2017

kodeine commented Jul 19, 2017 via email •

edited

Loading

danbucholtz commented Jul 19, 2017

kodeine commented Jul 19, 2017

kodeine commented Jul 19, 2017

trebor678 commented Jul 20, 2017

danbucholtz commented Jul 21, 2017

kodeine commented Jul 25, 2017

danbucholtz commented Jul 26, 2017

kodeine commented Jul 28, 2017

kodeine commented Jul 29, 2017 •

edited

Loading

kodeine commented Jul 31, 2017 •

edited

Loading

kodeine commented Aug 1, 2017

darmie commented Jan 9, 2018

AOT issue after upgrade to 2.0.2 #1112

AOT issue after upgrade to 2.0.2 #1112

Comments

kodeine commented Jul 14, 2017

Short description of the problem:

danbucholtz commented Jul 14, 2017

kodeine commented Jul 14, 2017

danbucholtz commented Jul 14, 2017

kodeine commented Jul 14, 2017

kodeine commented Jul 14, 2017

marcorosi commented Jul 14, 2017

danbucholtz commented Jul 14, 2017

kodeine commented Jul 16, 2017 • edited Loading

kodeine commented Jul 18, 2017 • edited Loading

vkniazeu commented Jul 18, 2017

kodeine commented Jul 18, 2017

vkniazeu commented Jul 18, 2017

kodeine commented Jul 18, 2017

vkniazeu commented Jul 18, 2017

kodeine commented Jul 18, 2017

danbucholtz commented Jul 19, 2017

kodeine commented Jul 19, 2017

danbucholtz commented Jul 19, 2017

kodeine commented Jul 19, 2017 via email • edited Loading

danbucholtz commented Jul 19, 2017

kodeine commented Jul 19, 2017

kodeine commented Jul 19, 2017

trebor678 commented Jul 20, 2017

danbucholtz commented Jul 21, 2017

kodeine commented Jul 25, 2017

danbucholtz commented Jul 26, 2017

kodeine commented Jul 28, 2017

kodeine commented Jul 29, 2017 • edited Loading

kodeine commented Jul 31, 2017 • edited Loading

kodeine commented Aug 1, 2017

darmie commented Jan 9, 2018

kodeine commented Jul 16, 2017 •

edited

Loading

kodeine commented Jul 18, 2017 •

edited

Loading

kodeine commented Jul 19, 2017 via email •

edited

Loading

kodeine commented Jul 29, 2017 •

edited

Loading

kodeine commented Jul 31, 2017 •

edited

Loading