Skip to content
This repository was archived by the owner on May 1, 2020. It is now read-only.

Commit e4b5c59

Browse files
committed
fix(bonjour): remove bonjour as its causing trouble for users on Windows without git
1 parent af7ac0d commit e4b5c59

File tree

2 files changed

+1
-35
lines changed

2 files changed

+1
-35
lines changed

src/dev-server/bonjour.ts

Lines changed: 0 additions & 28 deletions
This file was deleted.

src/serve.ts

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,6 @@ import open from './util/open';
88
import { createNotificationServer } from './dev-server/notification-server';
99
import { createHttpServer } from './dev-server/http-server';
1010
import { createLiveReloadServer } from './dev-server/live-reload';
11-
import { createBonjourService } from './dev-server/bonjour';
1211
import { ServeConfig, IONIC_LAB_URL } from './dev-server/serve-config';
1312
import { findClosestOpenPorts } from './util/network';
1413

@@ -47,7 +46,7 @@ export function serve(context: BuildContext) {
4746
useServerLogs: useServerLogs(context),
4847
useProxy: useProxy(context),
4948
notifyOnConsoleLog: sendClientConsoleLogs(context),
50-
devapp: useBonjour(context)
49+
devapp: false
5150
};
5251

5352
createNotificationServer(config);
@@ -57,7 +56,6 @@ export function serve(context: BuildContext) {
5756
return watch(context);
5857
})
5958
.then(() => {
60-
createBonjourService(config);
6159
onReady(config, context);
6260
return config;
6361
}, (err: BuildError) => {
@@ -143,10 +141,6 @@ function browserOption(context: BuildContext): string {
143141
return getConfigValue(context, '--browseroption', '-o', 'IONIC_BROWSEROPTION', 'ionic_browseroption', null);
144142
}
145143

146-
function useBonjour(context: BuildContext): boolean {
147-
return hasConfigValue(context, '--devapp', '-D', 'devapp', false);
148-
}
149-
150144
function launchLab(context: BuildContext): boolean {
151145
return hasConfigValue(context, '--lab', '-l', 'ionic_lab', false);
152146
}

0 commit comments

Comments
 (0)