Skip to content
This repository was archived by the owner on May 1, 2020. It is now read-only.

Commit beaf0d3

Browse files
authored
feat(generators): refactor generators
* feat(generators): handle new cli scripts * feat(generators): make tests pass * feat(generators): handling common moudle files * feat(generators): fix failing test * feat(generators): camelCase for pipe names * feature(helpers): added snake case and constant case for manipulating strings * feat(generators): add option for creating a constants file * feat(generators): fix test for CI
1 parent 9e19890 commit beaf0d3

File tree

9 files changed

+446
-211
lines changed

9 files changed

+446
-211
lines changed

src/generators.ts

Lines changed: 9 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -4,9 +4,9 @@ import { hydrateRequest, hydrateTabRequest, getNgModules, GeneratorOption, Gener
44

55
export { getNgModules, GeneratorOption, GeneratorRequest };
66

7-
export function processPageRequest(context: BuildContext, name: string) {
8-
const hydratedRequest = hydrateRequest(context, { type: 'page', name });
9-
return generateTemplates(context, hydratedRequest);
7+
export function processPageRequest(context: BuildContext, name: string, includeNgModule: any, includePageConstants: any) {
8+
const hydratedRequest = hydrateRequest(context, { type: 'page', name, includeNgModule });
9+
return generateTemplates(context, hydratedRequest, includePageConstants);
1010
}
1111

1212
export function processPipeRequest(context: BuildContext, name: string, ngModulePath: string) {
@@ -25,18 +25,17 @@ export function processProviderRequest(context: BuildContext, name: string, ngMo
2525
return nonPageFileManipulation(context, name, ngModulePath, 'provider');
2626
}
2727

28-
export function processTabsRequest(context: BuildContext, name: string, tabs: string[]) {
29-
const tabHydratedRequests = tabs.map((tab) => hydrateRequest(context, { type: 'page', name: tab }));
30-
const hydratedRequest = hydrateTabRequest(context, { type: 'tabs', name, tabs: tabHydratedRequests });
28+
export function processTabsRequest(context: BuildContext, name: string, tabs: any[], includeNgModule: any, includePageConstants: any) {
29+
const tabHydratedRequests = tabs.map((tab) => hydrateRequest(context, { type: 'page', name: tab, includeNgModule}));
30+
const hydratedRequest = hydrateTabRequest(context, { type: 'tabs', name, includeNgModule, tabs: tabHydratedRequests });
3131

32-
return generateTemplates(context, hydratedRequest).then(() => {
32+
return generateTemplates(context, hydratedRequest, includePageConstants).then(() => {
3333
const promises = tabHydratedRequests.map((hydratedRequest) => {
34-
return generateTemplates(context, hydratedRequest);
34+
return generateTemplates(context, hydratedRequest, includePageConstants);
3535
});
3636

3737
return Promise.all(promises);
38-
})
39-
.then((tabs) => {
38+
}).then((tabs) => {
4039
tabsModuleManipulation(tabs, hydratedRequest, tabHydratedRequests);
4140
});
4241
}

src/generators/constants.ts

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,12 @@
11
export const CLASSNAME_VARIABLE = '$CLASSNAME';
22
export const TAB_CONTENT_VARIABLE = '$TAB_CONTENT';
33
export const TAB_VARIABLES_VARIABLE = '$TAB_VARIABLES';
4+
export const TABS_IMPORTSTATEMENT_VARIABLE = '$TABS_IMPORTSTATEMENT';
45
export const FILENAME_VARIABLE = '$FILENAME';
6+
export const PIPENAME_VARIABLE = '$PIPENAME';
57
export const SUPPLIEDNAME_VARIABLE = '$SUPPLIEDNAME';
6-
8+
export const IMPORTSTATEMENT_VARIABLE = '$IMPORTSTATEMENT';
9+
export const IONICPAGE_VARIABLE = '$IONICPAGE';
710
export const KNOWN_FILE_EXTENSION = '.tmpl';
811

912
export const SPEC_FILE_EXTENSION = 'spec.ts';

0 commit comments

Comments
 (0)