Skip to content
This repository was archived by the owner on May 1, 2020. It is now read-only.

Commit 5c00970

Browse files
committed
fix(serve): allow multiple arguments in console.log
fixes ionic-team/ionic-cli#2243
1 parent 8e64407 commit 5c00970

File tree

1 file changed

+7
-5
lines changed

1 file changed

+7
-5
lines changed

src/dev-server/notification-server.ts

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -79,12 +79,13 @@ export function createNotificationServer(config: ServeConfig) {
7979
// we've successfully connected
8080
wsServer = ws;
8181

82-
wsServer.on('message', (incomingMessage: string) => {
82+
wsServer.on('message', (incomingMessage: any) => {
8383
// incoming message from the client
8484
try {
8585
printMessageFromClient(JSON.parse(incomingMessage));
8686
} catch (e) {
8787
Logger.error(`error opening ws message: ${incomingMessage}`);
88+
Logger.error(e.stack ? e.stack : e);
8889
}
8990
});
9091

@@ -112,22 +113,23 @@ export function createNotificationServer(config: ServeConfig) {
112113
function printConsole(msg: WsMessage) {
113114
const args = msg.data;
114115
args[0] = `console.${msg.type}: ${args[0]}`;
116+
const log = args.join(' ');
115117

116118
switch (msg.type) {
117119
case 'error':
118-
Logger.error.apply(this, args);
120+
Logger.error(log);
119121
break;
120122

121123
case 'warn':
122-
Logger.warn.apply(this, args);
124+
Logger.warn(log);
123125
break;
124126

125127
case 'debug':
126-
Logger.debug.apply(this, args);
128+
Logger.debug(log);
127129
break;
128130

129131
default:
130-
Logger.info.apply(this, args);
132+
Logger.info(log);
131133
break;
132134
}
133135
}

0 commit comments

Comments
 (0)