refactor(preprocess): require flags for optimizations and processing deep links

danbucholtz · danbucholtz · commit 49d7970182ff · 2017-02-07T23:58:20.000-06:00
diff --git a/src/preprocess.ts b/src/preprocess.ts
@@ -22,7 +22,8 @@ export function preprocess(context: BuildContext) {
 }
 
 function preprocessWorker(context: BuildContext) {
-  return deepLinking(context)
+  const deepLinksPromise = getBooleanPropertyValue(Constants.ENV_EXPERIMENTAL_PARSE_DEEPLINKS) ? deepLinking(context) : Promise.resolve();
+  return deepLinksPromise
     .then(() => {
       if (context.optimizeJs) {
         return optimization(context, null);
@@ -50,7 +51,8 @@ export function writeFilesToDisk(context: BuildContext) {
 }
 
 export function preprocessUpdate(changedFiles: ChangedFile[], context: BuildContext) {
-  const promises: Promise<any>[] = [];
-  promises.push(deepLinkingUpdate(changedFiles, context));
-  return Promise.all(promises);
+  if (getBooleanPropertyValue(Constants.ENV_EXPERIMENTAL_PARSE_DEEPLINKS)) {
+    return deepLinkingUpdate(changedFiles, context);
+  }
+  return Promise.resolve();
 }

Original file line number	Diff line number	Diff line change
`@@ -22,7 +22,8 @@ export function preprocess(context: BuildContext) {`
`22`	`22`	`}`
`23`	`23`
`24`	`24`	`function preprocessWorker(context: BuildContext) {`
`25`		`- return deepLinking(context)`
	`25`	`+ const deepLinksPromise = getBooleanPropertyValue(Constants.ENV_EXPERIMENTAL_PARSE_DEEPLINKS) ? deepLinking(context) : Promise.resolve();`
	`26`	`+ return deepLinksPromise`
`26`	`27`	`.then(() => {`
`27`	`28`	`if (context.optimizeJs) {`
`28`	`29`	`return optimization(context, null);`
`@@ -50,7 +51,8 @@ export function writeFilesToDisk(context: BuildContext) {`
`50`	`51`	`}`
`51`	`52`
`52`	`53`	`export function preprocessUpdate(changedFiles: ChangedFile[], context: BuildContext) {`
`53`		`- const promises: Promise<any>[] = [];`
`54`		`- promises.push(deepLinkingUpdate(changedFiles, context));`
`55`		`- return Promise.all(promises);`
	`54`	`+ if (getBooleanPropertyValue(Constants.ENV_EXPERIMENTAL_PARSE_DEEPLINKS)) {`
	`55`	`+ return deepLinkingUpdate(changedFiles, context);`
	`56`	`+ }`
	`57`	`+ return Promise.resolve();`
`56`	`58`	`}`