Skip to content

Commit b52d0ce

Browse files
committed
fix(android): required compatibility for Gradle 8 in android modules
With gratitude to @AndreiCalazans for starting this process of gradle 8 compatibility, there were a few modules that still needed updates to handle the new default-off BuildConfig setting breaking change from gradle 8 This is required for react-native 0.73 compatibility (currently in RC phase) as they adopt gradle 8 there
1 parent 2d8ac14 commit b52d0ce

File tree

4 files changed

+24
-0
lines changed

4 files changed

+24
-0
lines changed

packages/analytics/android/build.gradle

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -121,6 +121,12 @@ android {
121121
firebaseJsonAutomaticScreenReportingEnabled: automaticScreenReportingEnabled
122122
]
123123
}
124+
125+
buildFeatures {
126+
// AGP 8 no longer builds config by default
127+
buildConfig true
128+
}
129+
124130
lintOptions {
125131
disable 'GradleCompatible'
126132
abortOnError false

packages/in-app-messaging/android/build.gradle

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -93,6 +93,12 @@ android {
9393
firebaseJsonAutoInitEnabled: dataCollectionEnabled
9494
]
9595
}
96+
97+
buildFeatures {
98+
// AGP 8 no longer builds config by default
99+
buildConfig true
100+
}
101+
96102
lintOptions {
97103
disable 'GradleCompatible'
98104
abortOnError false

packages/messaging/android/build.gradle

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -102,6 +102,12 @@ android {
102102
firebaseJsonNotificationColor: notificationColor
103103
]
104104
}
105+
106+
buildFeatures {
107+
// AGP 8 no longer builds config by default
108+
buildConfig true
109+
}
110+
105111
lintOptions {
106112
disable 'GradleCompatible'
107113
abortOnError false

packages/perf/android/build.gradle

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -101,6 +101,12 @@ android {
101101
firebaseJsonCollectionDeactivated: collectionDeactivated
102102
]
103103
}
104+
105+
buildFeatures {
106+
// AGP 8 no longer builds config by default
107+
buildConfig true
108+
}
109+
104110
lintOptions {
105111
disable 'GradleCompatible'
106112
abortOnError false

0 commit comments

Comments
 (0)