From 186568699d3170a6c4aef0ce6a320d94f77efc95 Mon Sep 17 00:00:00 2001
From: ota <y.ohta.z3@future.co.jp>
Date: Wed, 12 Aug 2020 09:21:14 +0900
Subject: [PATCH] Fix false negatives in `<i18n>` block without `<template>` in
 `no-unused-keys` rule.

---
 lib/utils/parsers/index.ts        | 51 ++++++++++++++++++++++++++-----
 tests/lib/rules/no-unused-keys.ts | 45 +++++++++++++++++++++++++++
 2 files changed, 88 insertions(+), 8 deletions(-)

diff --git a/lib/utils/parsers/index.ts b/lib/utils/parsers/index.ts
index b7ac6b93..47094689 100644
--- a/lib/utils/parsers/index.ts
+++ b/lib/utils/parsers/index.ts
@@ -56,6 +56,46 @@ export interface YAMLParsed extends Parsed<YAMLAST.YAMLNode> {
   ast: YAMLAST.YAMLProgram
 }
 
+function hasEndTag(
+  element: VAST.VElement
+): element is VAST.VElement & { endTag: VAST.VEndTag } {
+  return !!element.endTag
+}
+
+function getSourceCodeString(
+  context: RuleContext,
+  i18nBlock: VAST.VElement & { endTag: VAST.VEndTag }
+): string {
+  const tokenStore = context.parserServices.getTemplateBodyTokenStore()
+  const tokens = tokenStore.getTokensBetween(
+    i18nBlock.startTag,
+    i18nBlock.endTag
+  )
+  if (
+    tokens.length ||
+    i18nBlock.startTag.range[1] === i18nBlock.endTag.range[0]
+  ) {
+    return tokens.map(t => t.value).join('')
+  }
+  // without <template></template>
+  const df = context.parserServices.getDocumentFragment?.()
+  if (!df) {
+    return ''
+  }
+  const start = i18nBlock.startTag.range[1]
+  const end = i18nBlock.endTag.range[0]
+  let sourceCode = ''
+  for (const token of df.tokens) {
+    if (start <= token.range[0] && token.range[1] <= end) {
+      sourceCode += token.value
+    }
+    if (end <= token.range[0]) {
+      break
+    }
+  }
+  return sourceCode
+}
+
 /**
  * @param {RuleContext} context
  * @param {VElement} i18nBlock
@@ -68,19 +108,14 @@ function parseInI18nBlock<P extends JSONAST.JSONProgram | YAMLAST.YAMLProgram>(
     option: unknown
   ) => { ast: P; visitorKeys: VisitorKeys }
 ) {
-  if (!i18nBlock.endTag) {
+  if (!hasEndTag(i18nBlock)) {
     return null
   }
-  const offsetIndex = i18nBlock.startTag.range[1]
-  const tokenStore = context.parserServices.getTemplateBodyTokenStore()
-  const tokens = tokenStore.getTokensBetween(
-    i18nBlock.startTag,
-    i18nBlock.endTag
-  )
-  const sourceString = tokens.map(t => t.value).join('')
+  const sourceString = getSourceCodeString(context, i18nBlock)
   if (!sourceString.trim()) {
     return null
   }
+  const offsetIndex = i18nBlock.startTag.range[1]
   const sourceCode = context.getSourceCode()
   const locationFixer = new LocationFixer(
     sourceCode,
diff --git a/tests/lib/rules/no-unused-keys.ts b/tests/lib/rules/no-unused-keys.ts
index 3183f94b..23f60f8c 100644
--- a/tests/lib/rules/no-unused-keys.ts
+++ b/tests/lib/rules/no-unused-keys.ts
@@ -872,6 +872,51 @@ ${' '.repeat(6)}
         "unused 'unuse' key",
         "unused 'array-unuse[0]' key"
       ]
+    },
+    {
+      // without <template>
+      filename: 'test.vue',
+      code: `
+      <i18n lang="yaml" locale="en">
+      test: Test
+      </i18n>
+      <script>
+      // without <template>
+      export default {
+        render (createElement) {}
+      }
+      </script>`,
+      options: [{ enableFix: true }],
+      output: `
+      <i18n lang="yaml" locale="en">
+      {}
+      </i18n>
+      <script>
+      // without <template>
+      export default {
+        render (createElement) {}
+      }
+      </script>`,
+      errors: [
+        {
+          message: "unused 'test' key",
+          suggestions: [
+            {
+              desc: "Remove the 'test' key.",
+              output: `
+      <i18n lang="yaml" locale="en">
+      {}
+      </i18n>
+      <script>
+      // without <template>
+      export default {
+        render (createElement) {}
+      }
+      </script>`
+            }
+          ]
+        }
+      ]
     }
   ]
 })