Skip to content

Commit d215ab4

Browse files
vladimirolteankuba-moo
authored andcommitted
net: mdio-mux: show errors on probe failure
Showing the precise error symbols can help debugging probe issues, such as the recent -EIO error in of_mdiobus_register() caused by the lack of bus->read_c45() and bus->write_c45() methods. Signed-off-by: Vladimir Oltean <[email protected]> Reviewed-by: Andrew Lunn <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Jakub Kicinski <[email protected]>
1 parent b3cb7a8 commit d215ab4

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

drivers/net/mdio/mdio-mux.c

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -190,8 +190,8 @@ int mdio_mux_init(struct device *dev,
190190
r = of_property_read_u32(child_bus_node, "reg", &v);
191191
if (r) {
192192
dev_err(dev,
193-
"Error: Failed to find reg for child %pOF\n",
194-
child_bus_node);
193+
"Error: Failed to find reg for child %pOF: %pe\n",
194+
child_bus_node, ERR_PTR(r));
195195
continue;
196196
}
197197

@@ -229,8 +229,8 @@ int mdio_mux_init(struct device *dev,
229229
}
230230
devm_kfree(dev, cb);
231231
dev_err(dev,
232-
"Error: Failed to register MDIO bus for child %pOF\n",
233-
child_bus_node);
232+
"Error: Failed to register MDIO bus for child %pOF: %pe\n",
233+
child_bus_node, ERR_PTR(r));
234234
} else {
235235
cb->next = pb->children;
236236
pb->children = cb;

0 commit comments

Comments
 (0)