Skip to content

Commit 8d182d5

Browse files
JasonXingkuba-moo
authored andcommitted
i40e: remove fake support of rx-frames-irq
Since we never support this feature for I40E driver, we don't have to display the value when using 'ethtool -c eth0'. Before this patch applied, the rx-frames-irq is 256 which is consistent with tx-frames-irq. Apparently it could mislead users. Signed-off-by: Jason Xing <[email protected]> Tested-by: Pucha Himasekhar Reddy <[email protected]> (A Contingent worker at Intel) Reviewed-by: Simon Horman <[email protected]> Signed-off-by: Tony Nguyen <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Jakub Kicinski <[email protected]>
1 parent 0d2f3b8 commit 8d182d5

File tree

1 file changed

+2
-3
lines changed

1 file changed

+2
-3
lines changed

drivers/net/ethernet/intel/i40e/i40e_ethtool.c

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2893,7 +2893,6 @@ static int __i40e_get_coalesce(struct net_device *netdev,
28932893
struct i40e_vsi *vsi = np->vsi;
28942894

28952895
ec->tx_max_coalesced_frames_irq = vsi->work_limit;
2896-
ec->rx_max_coalesced_frames_irq = vsi->work_limit;
28972896

28982897
/* rx and tx usecs has per queue value. If user doesn't specify the
28992898
* queue, return queue 0's value to represent.
@@ -3027,7 +3026,7 @@ static int __i40e_set_coalesce(struct net_device *netdev,
30273026
struct i40e_pf *pf = vsi->back;
30283027
int i;
30293028

3030-
if (ec->tx_max_coalesced_frames_irq || ec->rx_max_coalesced_frames_irq)
3029+
if (ec->tx_max_coalesced_frames_irq)
30313030
vsi->work_limit = ec->tx_max_coalesced_frames_irq;
30323031

30333032
if (queue < 0) {
@@ -5784,7 +5783,7 @@ static const struct ethtool_ops i40e_ethtool_recovery_mode_ops = {
57845783

57855784
static const struct ethtool_ops i40e_ethtool_ops = {
57865785
.supported_coalesce_params = ETHTOOL_COALESCE_USECS |
5787-
ETHTOOL_COALESCE_MAX_FRAMES_IRQ |
5786+
ETHTOOL_COALESCE_TX_MAX_FRAMES_IRQ |
57885787
ETHTOOL_COALESCE_USE_ADAPTIVE |
57895788
ETHTOOL_COALESCE_RX_USECS_HIGH |
57905789
ETHTOOL_COALESCE_TX_USECS_HIGH,

0 commit comments

Comments
 (0)